Flag myIpAddress requests for chromeos

net/proxy/proxy_resolver_v8_tracing.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_resolver_v8_tracing.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/stringprintf.h"
@@ skipping 955 matching lines @@
 
 // static
 HostResolver::RequestInfo ProxyResolverV8Tracing::Job::MakeDnsRequestInfo(
     const std::string& host, ResolveDnsOperation op) {
   HostPortPair host_port = HostPortPair(host, 80);
   if (op == MY_IP_ADDRESS || op == MY_IP_ADDRESS_EX) {
     host_port.set_host(GetHostName());
   }
 
   HostResolver::RequestInfo info(host_port);
-
+  // Flag myIpAddress requests.
+  if (op == MY_IP_ADDRESS || op == MY_IP_ADDRESS_EX) {
+    // TODO: Provide a RequestInfo construction mechanism that does not

[eroman, 2014/06/26 22:14:22]

TODO(stevnjb):

Note that the name in parens is NOT the person assigned the task. It is the
person who wrote the comment.

If you prefer you can put my name in there instead.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=TODO_C...

[stevenjb, 2014/06/26 22:21:24]

Well, actually it says "identifier of the person who can best provide context
about the problem referenced by the TODO." I was hesitant to put my name there
because all of the changes here outside of src/chromeos are still a bit beyond
my purview, although I suppose I know just enough to be dangerous at this point.

+    // require a hostname and sets is_my_ip_address to true instead of this.
+    info.set_is_my_ip_address(true);
+  }
   // The non-ex flavors are limited to IPv4 results.
   if (op == MY_IP_ADDRESS || op == DNS_RESOLVE) {
     info.set_address_family(ADDRESS_FAMILY_IPV4);
   }
 
   return info;
 }
 
 std::string ProxyResolverV8Tracing::Job::MakeDnsCacheKey(
     const std::string& host, ResolveDnsOperation op) {
@@ skipping 177 matching lines @@
   DCHECK(!set_pac_script_job_.get());
   CHECK_EQ(0, num_outstanding_callbacks_);
 
   set_pac_script_job_ = new Job(this);
   set_pac_script_job_->StartSetPacScript(script_data, callback);
 
   return ERR_IO_PENDING;
 }
 
 }  // namespace net