Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 355853003: ARM64: optimize TruncateDoubleToI (Closed)

Created:
6 years, 5 months ago by vincent.belliard
Modified:
6 years, 5 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM64: optimize TruncateDoubleToI R=ulan@chromium.org, bmeurer@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : add specialized push function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/arm64/macro-assembler-arm64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vincent.belliard
Use the same mechanism used by Push for pushing lr and one double. Before patch: ...
6 years, 5 months ago (2014-06-27 15:09:24 UTC) #1
ulan
If this is performance neutral, I'd prefer not landing this because it reduces readability.
6 years, 5 months ago (2014-06-30 12:51:53 UTC) #2
vincent.belliard
It only reduces the code size by one instruction for each TruncateDoubleToI
6 years, 5 months ago (2014-06-30 13:03:08 UTC) #3
ulan
An alternative would be to introduce Push(Register, DoubleRegister) which makes this optimization and keeps TruncateDoubleToI ...
6 years, 5 months ago (2014-06-30 13:10:11 UTC) #4
vincent.belliard
done
6 years, 5 months ago (2014-06-30 15:02:56 UTC) #5
ulan
6 years, 5 months ago (2014-06-30 15:22:58 UTC) #6
Thanks, lgtm.

Powered by Google App Engine
This is Rietveld 408576698