Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 355853002: Componentize TemplateURLPrepopulateData, DefaultSearchManager and DefaultSearchPolicyHandler (Closed)

Created:
6 years, 6 months ago by hashimoto
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, tfarina, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, dhollowa+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

Componentize TemplateURLPrepopulateData, DefaultSearchManager and DefaultSearchPolicyHandler Move TemplateURLPrepopulateData, DefaultSearchManager and DefaultSearchPolicyHandler from chrome/browser/search_engines to components/search_engines. Fix DEPS and gyp. Fix template_url_prepopulate_data.cc to stop including unnecessary headers. BUG=371535 TEST=build TBR=sky@chromium.org for include fix under chrome/browser TBR=aruslan@chromium.org for DEPS and include changes under chrome/android TBR=blundell@chromium.org as an owner of new dependencies (components/policy and components/pref_registry) added to components/search_engines/DEPS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279792

Patch Set 1 #

Patch Set 2 : Missing comma in gyp #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2569 lines) Patch
M chrome/android/shell/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/shell/chrome_main_delegate_chrome_shell_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/in_process_importer_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/search_engines/default_search_manager.h View 1 chunk +0 lines, -164 lines 0 comments Download
D chrome/browser/search_engines/default_search_manager.cc View 1 chunk +0 lines, -415 lines 0 comments Download
M chrome/browser/search_engines/default_search_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/search_engines/default_search_policy_handler.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/search_engines/default_search_policy_handler.cc View 1 chunk +0 lines, -461 lines 0 comments Download
M chrome/browser/search_engines/default_search_policy_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/default_search_pref_migration.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/search_engines/template_url_prepopulate_data.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 chunk +0 lines, -1311 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_scraper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -6 lines 2 comments Download
M components/search_engines.gypi View 1 2 chunks +9 lines, -0 lines 0 comments Download
M components/search_engines/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/search_engines/default_search_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/search_engines/default_search_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/search_engines/default_search_policy_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/search_engines/default_search_policy_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/search_engines/template_url_prepopulate_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/search_engines/template_url_prepopulate_data.cc View 3 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
6 years, 6 months ago (2014-06-25 17:24:07 UTC) #1
Peter Kasting
LGTM
6 years, 6 months ago (2014-06-25 18:57:35 UTC) #2
hashimoto
TBRing: sky@chromium.org for include fix under chrome/browser aruslan@chromium.org for DEPS and include changes under chrome/android ...
6 years, 6 months ago (2014-06-25 19:27:14 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-06-25 19:27:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/355853002/20001
6 years, 6 months ago (2014-06-25 19:28:39 UTC) #5
commit-bot: I haz the power
Change committed as 279792
6 years, 6 months ago (2014-06-25 19:58:17 UTC) #6
brettw
https://codereview.chromium.org/355853002/diff/20001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (left): https://codereview.chromium.org/355853002/diff/20001/chrome/chrome_browser.gypi#oldcode1631 chrome/chrome_browser.gypi:1631: 'browser/search_engines/default_search_policy_handler.cc', Please be careful when making .gyp changes like ...
6 years, 6 months ago (2014-06-25 21:36:43 UTC) #7
hashimoto
6 years, 6 months ago (2014-06-25 21:43:07 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/355853002/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (left):

https://codereview.chromium.org/355853002/diff/20001/chrome/chrome_browser.gy...
chrome/chrome_browser.gypi:1631:
'browser/search_engines/default_search_policy_handler.cc',
On 2014/06/25 21:36:43, brettw wrote:
> Please be careful when making .gyp changes like this. This file is referenced
in
> two exclusion/inclusion rules which weren't removed.
Sorry, I was relying too much on tools/git/move_source_file.py.
> 
> I'll fix this in a patch I have to rework this file somewhat.
Thanks,

Powered by Google App Engine
This is Rietveld 408576698