Adjust autofill phone number format.

components/autofill/core/browser/phone_number_i18n.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/phone_number_i18n.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 45 matching lines @@
                            const base::string16& country_code,
                            base::string16* formatted_number,
                            base::string16* normalized_number) {
   PhoneNumberUtil::PhoneNumberFormat format =
       country_code.empty() ?
       PhoneNumberUtil::NATIONAL :
       PhoneNumberUtil::INTERNATIONAL;
 
   PhoneNumberUtil* phone_util = PhoneNumberUtil::GetInstance();
   std::string processed_number;
-  phone_util->Format(number, format, &processed_number);
 
-  if (formatted_number)
-    *formatted_number = base::UTF8ToUTF16(processed_number);
+  std::string region_code;
+  phone_util->GetRegionCodeForNumber(number, &region_code);
+
+  // Formats a phone number using the original phone number format that the
+  // number is parsed from.
+  // This applies to the following cases:
+  //   The phone number is an international phone number and has a leading '+'
+  //   sign.
+  //   The number is from the default country. This happens mostly for numbers
+  //   written in the nation format.

[Ilya Sherman, 2014/07/11 03:43:40]

nit: "nation" -> "national"

+  if (number.has_country_code_source() &&
+      ((number.country_code_source() ==
+            PhoneNumber::FROM_NUMBER_WITH_PLUS_SIGN &&
+        format == PhoneNumberUtil::INTERNATIONAL) ||
+       number.country_code_source() ==
+           PhoneNumber::FROM_DEFAULT_COUNTRY)) {
+    phone_util->FormatInOriginalFormat(number, region_code, &processed_number);
+  } else {
+    phone_util->Format(number, format, &processed_number);
+  }
+
+  if (formatted_number) {
+    *formatted_number = (processed_number[0] == '+' && region_code == "US" ?

[Ilya Sherman, 2014/07/11 03:43:40]

Please add comments to explain why the US is special-cased.

+        base::UTF8ToUTF16(processed_number.substr(1,
+                                                  processed_number.length())) :
+            base::UTF8ToUTF16(processed_number));

[Ilya Sherman, 2014/07/11 03:43:40]

Hmm, this ternary expression is a bit hard to read.  I think it would be a
little cleaner if written as an if/else.  WDYT?

+  }
 
   if (normalized_number) {
-    phone_util->NormalizeDigitsOnly(&processed_number);
+    // Keep the leading '+' while normalising numbers, excluding US numbers.
+    if (processed_number[0] == '+' && region_code != "US") {
+      processed_number = processed_number.substr(1, processed_number.length());
+      phone_util->NormalizeDigitsOnly(&processed_number);
+      processed_number.insert(processed_number.begin(), '+');
+    } else {
+      phone_util->NormalizeDigitsOnly(&processed_number);
+    }
     *normalized_number = base::UTF8ToUTF16(processed_number);
   }
 }
 
 }  // namespace
 
 namespace i18n {
 
 // Parses the number stored in |value| as it should be interpreted in the given
 // |default_region|, and stores the results into the remaining arguments.
@@ skipping 10 matching lines @@
   number->clear();
   *i18n_number = PhoneNumber();
 
   std::string number_text(base::UTF16ToUTF8(value));
 
   // Parse phone number based on the region.
   PhoneNumberUtil* phone_util = PhoneNumberUtil::GetInstance();
 
   // The |default_region| should already be sanitized.
   DCHECK_EQ(2U, default_region.size());
-  if (phone_util->Parse(number_text, default_region, i18n_number) !=
+  if (phone_util->ParseAndKeepRawInput(number_text,
+                                       default_region,
+                                       i18n_number) !=
           PhoneNumberUtil::NO_PARSING_ERROR) {
     return false;
   }
 
   if (!IsValidPhoneNumber(*i18n_number))
     return false;
 
   std::string national_significant_number;
   phone_util->GetNationalSignificantNumber(*i18n_number,
                                            &national_significant_number);
@@ skipping 186 matching lines @@
   number_ = other.number_;
 
   formatted_number_ = other.formatted_number_;
   whole_number_ = other.whole_number_;
 
   return *this;
 }
 
 }  // namespace i18n
 }  // namespace autofill