Issue 355823002: DevTools: Use in JavaScriptSourceFrame current target's debuggerModel instead of WebInspector.debug

Issue 355823002: DevTools: Use in JavaScriptSourceFrame current target's debuggerModel instead of WebInspector.debug (Closed)

Created:
6 years, 6 months ago by sergeyv

Modified:
6 years, 6 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Use in JavaScriptSourceFrame current target's debuggerModel instead of WebInspector.debuggerModel BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177036

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address vsevik's comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	Source/devtools/front_end/sources/JavaScriptSourceFrame.js	View	1	4 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://codereview.chromium.org/355823002/diff/1/Source/devtools/front_end/sources/JavaScriptSourceFrame.js File Source/devtools/front_end/sources/JavaScriptSourceFrame.js (right): https://codereview.chromium.org/355823002/diff/1/Source/devtools/front_end/sources/JavaScriptSourceFrame.js#newcode507 Source/devtools/front_end/sources/JavaScriptSourceFrame.js:507: var target = selectedCallFrame.target(); The target might have ...

6 years, 6 months ago (2014-06-26 07:50:32 UTC) #3

sergeyv

https://codereview.chromium.org/355823002/diff/1/Source/devtools/front_end/sources/JavaScriptSourceFrame.js File Source/devtools/front_end/sources/JavaScriptSourceFrame.js (right): https://codereview.chromium.org/355823002/diff/1/Source/devtools/front_end/sources/JavaScriptSourceFrame.js#newcode507 Source/devtools/front_end/sources/JavaScriptSourceFrame.js:507: var target = selectedCallFrame.target(); On 2014/06/26 11:50:32, vsevik wrote: ...

6 years, 6 months ago (2014-06-26 09:21:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/355823002/20001

6 years, 6 months ago (2014-06-26 09:21:56 UTC) #6

Message was sent while issue was closed.

Change committed as 177036

Expand Messages | Collapse Messages