Source/core/rendering/svg/RenderSVGShape.h - Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGShape.h

Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix nit Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/custom/getBBox-perpendicular-polyline-expected.txt ('k') | Source/core/rendering/svg/SVGRenderSupport.cpp » ('j') | Source/core/rendering/svg/SVGRenderSupport.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGShape.h

diff --git a/Source/core/rendering/svg/RenderSVGShape.h b/Source/core/rendering/svg/RenderSVGShape.h

index 12a703f063b4f29d0e565710507ba66d9b7eb91d..518b5742001cbca58cf33989cc7a1c64a0351e1d 100644

--- a/Source/core/rendering/svg/RenderSVGShape.h

+++ b/Source/core/rendering/svg/RenderSVGShape.h

@@ -60,9 +60,10 @@ public:

return *m_path;

}

+ virtual bool isShapeEmpty() const { return path().isEmpty(); }

protected:

virtual void updateShapeFromElement();

- virtual bool isShapeEmpty() const { return path().isEmpty(); }

virtual bool shapeDependentStrokeContains(const FloatPoint&);

virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const;

float strokeWidth() const;