Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Side by Side Diff: Source/core/rendering/svg/RenderSVGShape.h

Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2006 Apple Computer, Inc 5 * Copyright (C) 2006 Apple Computer, Inc
6 * Copyright (C) 2009 Google, Inc. 6 * Copyright (C) 2009 Google, Inc.
7 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org> 7 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
8 * Copyright (C) 2011 University of Szeged 8 * Copyright (C) 2011 University of Szeged
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 virtual void strokeShape(GraphicsContext*) const; 53 virtual void strokeShape(GraphicsContext*) const;
54 54
55 bool nodeAtFloatPointInternal(const HitTestRequest&, const FloatPoint&, Poin terEventsHitRules); 55 bool nodeAtFloatPointInternal(const HitTestRequest&, const FloatPoint&, Poin terEventsHitRules);
56 56
57 Path& path() const 57 Path& path() const
58 { 58 {
59 ASSERT(m_path); 59 ASSERT(m_path);
60 return *m_path; 60 return *m_path;
61 } 61 }
62 62
63 virtual bool isRenderingDisabled() const
fs 2014/06/25 12:53:20 The implementation of this is essentially the same
Erik Dahlström (inactive) 2014/06/25 14:57:42 Done.
64 {
65 // Returning false by default ensures backwards compatibility for
fs 2014/06/25 12:53:20 This will probably be mute w/ the above, but - bac
Erik Dahlström (inactive) 2014/06/25 14:57:42 Done.
66 // elements that don't implement this method.
67 return false;
68 }
69
63 protected: 70 protected:
64 virtual void updateShapeFromElement(); 71 virtual void updateShapeFromElement();
65 virtual bool isShapeEmpty() const { return path().isEmpty(); } 72 virtual bool isShapeEmpty() const { return path().isEmpty(); }
66 virtual bool shapeDependentStrokeContains(const FloatPoint&); 73 virtual bool shapeDependentStrokeContains(const FloatPoint&);
67 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst; 74 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst;
68 float strokeWidth() const; 75 float strokeWidth() const;
69 bool hasPath() const { return m_path.get(); } 76 bool hasPath() const { return m_path.get(); }
70 bool hasSmoothStroke() const; 77 bool hasSmoothStroke() const;
71 78
72 bool hasNonScalingStroke() const { return style()->svgStyle()->vectorEffect( ) == VE_NON_SCALING_STROKE; } 79 bool hasNonScalingStroke() const { return style()->svgStyle()->vectorEffect( ) == VE_NON_SCALING_STROKE; }
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 bool m_needsBoundariesUpdate : 1; 126 bool m_needsBoundariesUpdate : 1;
120 bool m_needsShapeUpdate : 1; 127 bool m_needsShapeUpdate : 1;
121 bool m_needsTransformUpdate : 1; 128 bool m_needsTransformUpdate : 1;
122 }; 129 };
123 130
124 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGShape, isSVGShape()); 131 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGShape, isSVGShape());
125 132
126 } 133 }
127 134
128 #endif 135 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698