Source/core/rendering/svg/RenderSVGRect.h - Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/svg/RenderSVGRect.h

Issue 355813004: [SVG2] Elements that don't render shouldn't contribute to ancestor bboxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/svg/custom/getBBox-polyline-nodata.html ('K') | « Source/core/rendering/svg/RenderSVGPath.cpp ('k') | Source/core/rendering/svg/RenderSVGRect.cpp » ('j') | Source/core/rendering/svg/RenderSVGShape.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 University of Szeged	2 * Copyright (C) 2011 University of Szeged

3 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>	3 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>

4 * All rights reserved.	4 * All rights reserved.

5 *	5 *

6 * Redistribution and use in source and binary forms, with or without	6 * Redistribution and use in source and binary forms, with or without

7 * modification, are permitted provided that the following conditions	7 * modification, are permitted provided that the following conditions

8 * are met:	8 * are met:

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 29 matching lines...) Expand all Loading...
40	40

41 private:	41 private:

42 virtual const char* renderName() const OVERRIDE { return "RenderSVGRect"; }	42 virtual const char* renderName() const OVERRIDE { return "RenderSVGRect"; }

43	43

44 virtual void updateShapeFromElement() OVERRIDE;	44 virtual void updateShapeFromElement() OVERRIDE;

45 virtual bool isShapeEmpty() const OVERRIDE { return m_usePathFallback ? Rend erSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }	45 virtual bool isShapeEmpty() const OVERRIDE { return m_usePathFallback ? Rend erSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }

46 virtual void fillShape(GraphicsContext*) const OVERRIDE;	46 virtual void fillShape(GraphicsContext*) const OVERRIDE;

47 virtual void strokeShape(GraphicsContext*) const OVERRIDE;	47 virtual void strokeShape(GraphicsContext*) const OVERRIDE;

48 virtual bool shapeDependentStrokeContains(const FloatPoint&) OVERRIDE;	48 virtual bool shapeDependentStrokeContains(const FloatPoint&) OVERRIDE;

49 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst OVERRIDE;	49 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst OVERRIDE;

	50 virtual bool isRenderingDisabled() const OVERRIDE;

50	51

51 private:	52 private:

52 FloatRect m_innerStrokeRect;	53 FloatRect m_innerStrokeRect;

53 FloatRect m_outerStrokeRect;	54 FloatRect m_outerStrokeRect;

54 bool m_usePathFallback;	55 bool m_usePathFallback;

55 };	56 };

56	57

57 }	58 }

58	59

59 #endif	60 #endif

OLD	NEW