Issue 355793002: Do not unnecessarily expose execution state in debug event data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355793002: Do not unnecessarily expose execution state in debug event data. (Closed)

Created:
6 years, 6 months ago by Yang

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Do not unnecessarily expose execution state in debug event data. When we fire a debug event, we create duplicate execution state objects, one as argument for the debug event listener, one as property on the debug event data object. The latter is never used by chrome. R=yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22001

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -55 lines)			Patch
	M	src/debug.cc	View		3 chunks	+5 lines, -13 lines	0 comments	Download
	M	src/debug-debugger.js	View		6 chunks	+19 lines, -42 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

6 years, 6 months ago (2014-06-25 09:13:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22001 (presubmit successful).

Expand Messages | Collapse Messages