Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 355603003: Initialize a variable in GrDrawTarget::drawPaths (Closed)

Created:
6 years, 6 months ago by Kimmo Kinnunen
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1, rmistry, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@rebaseline-implement-text-with-nvpr
Project:
skia
Visibility:
Public.

Description

Initialize a variable in GrDrawTarget::drawPaths Initialize the device bounds rect variable before use in GrDrawTarget::drawPaths. Committed: https://skia.googlesource.com/skia/+/5da2fa436e62609153b990ef317733ade912f171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/gpu/GrDrawTarget.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Kimmo Kinnunen
Fixes Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/
6 years, 6 months ago (2014-06-24 11:17:49 UTC) #1
rmistry
Jim / Mike could you please take a look?
6 years, 6 months ago (2014-06-24 11:22:28 UTC) #2
mtklein
lgtm
6 years, 6 months ago (2014-06-24 12:26:54 UTC) #3
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-24 12:32:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/355603003/1
6 years, 6 months ago (2014-06-24 12:32:56 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 12:43:25 UTC) #6
Message was sent while issue was closed.
Change committed as 5da2fa436e62609153b990ef317733ade912f171

Powered by Google App Engine
This is Rietveld 408576698