Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 355573008: Split keyword related parts of WebDataService as KeywordWebDataService (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Split keyword related parts of WebDataService as KeywordWebDataService The new class KeywordWebDataService will be moved to components/search_engines with KeywordTable later. Move keyword related parts from web_data_service.{cc,h} to keyword_web_data_service.{cc,h}. Add a new ProfileErrorType enum. BUG=381572 TEST=build TBR=asvitkine@chromium.org for the enum addition in histograms.xml corresponding to the one in chrome/browser/ui/profile_error_dialog.h Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280969

Patch Set 1 : #

Patch Set 2 : Add OWNERS #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : s/KeywordBatchModeScoper/BatchModeScoper/ #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -654 lines) Patch
M chrome/browser/search_engines/template_url_service.h View 1 2 6 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 2 3 26 chunks +41 lines, -40 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/util.h View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/search_engines/util.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/profile_error_dialog.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/webdata/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/webdata/keyword_web_data_service.h View 1 2 3 4 5 chunks +23 lines, -195 lines 0 comments Download
A + chrome/browser/webdata/keyword_web_data_service.cc View 1 2 3 4 3 chunks +47 lines, -153 lines 0 comments Download
M chrome/browser/webdata/web_data_service.h View 7 chunks +0 lines, -89 lines 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 4 chunks +2 lines, -146 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 5 chunks +24 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
6 years, 5 months ago (2014-06-28 00:51:02 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/355573008/diff/40001/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): https://codereview.chromium.org/355573008/diff/40001/chrome/browser/search_engines/template_url_service.cc#newcode563 chrome/browser/search_engines/template_url_service.cc:563: KeywordWebDataService::KeywordBatchModeScoper keyword_scoper( Nit: If you rename KeywordBatchModeScoper to ...
6 years, 5 months ago (2014-06-30 22:50:02 UTC) #2
hashimoto
https://codereview.chromium.org/355573008/diff/40001/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): https://codereview.chromium.org/355573008/diff/40001/chrome/browser/search_engines/template_url_service.cc#newcode563 chrome/browser/search_engines/template_url_service.cc:563: KeywordWebDataService::KeywordBatchModeScoper keyword_scoper( On 2014/06/30 22:50:01, Peter Kasting wrote: > ...
6 years, 5 months ago (2014-07-01 01:06:51 UTC) #3
hashimoto
Alexei, could you review this change as an owner of histograms.xml?
6 years, 5 months ago (2014-07-01 01:11:02 UTC) #4
hashimoto
TBRing asvitkine@chromium.org for the enum addition in histograms.xml corresponding to the one in chrome/browser/ui/profile_error_dialog.h
6 years, 5 months ago (2014-07-02 00:28:46 UTC) #5
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-02 00:28:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/355573008/100001
6 years, 5 months ago (2014-07-02 00:29:05 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 03:41:41 UTC) #8
commit-bot: I haz the power
Change committed as 280969
6 years, 5 months ago (2014-07-02 07:30:53 UTC) #9
Alexei Svitkine (slow)
6 years, 5 months ago (2014-07-02 14:47:49 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698