Issue 355563004: Create package for incremental compilation.

Issue 355563004: Create package for incremental compilation. (Closed)

Created:
6 years, 6 months ago by ahe

Modified:
6 years, 6 months ago

Reviewers:
Johnni Winther, Bob Nystrom

CC:
reviews_dartlang.org, kasperl, lukechurch, floitsch, Bob Nystrom, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Create package for incremental compilation. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37653

Patch Set 1 : #

Total comments: 3

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -246 lines)			Patch
A +	dart/pkg/dart2js_incremental/lib/caching_compiler.dart	View	4 chunks	+10 lines, -25 lines	0 comments	Download
A	dart/pkg/dart2js_incremental/lib/dart2js_incremental.dart	View	1 chunk	+83 lines, -0 lines	0 comments	Download
A +	dart/pkg/dart2js_incremental/pubspec.yaml	View	1 chunk	+3 lines, -7 lines	1 comment	Download
M	dart/site/try/build_try.gyp	View	5 chunks	+9 lines, -2 lines	0 comments	Download
M	dart/site/try/src/Makefile	View	1 chunk	+1 line, -1 line	2 comments	Download
D	dart/site/try/src/caching_compiler.dart	View	1 chunk	+0 lines, -161 lines	0 comments	Download
M	dart/site/try/src/compiler_isolate.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/incremental/compile_all.dart	View	3 chunks	+12 lines, -16 lines	0 comments	Download
M	dart/tests/compiler/dart2js/incremental/hello_test.dart	View	4 chunks	+16 lines, -21 lines	0 comments	Download
D	dart/tests/compiler/dart2js/incremental/incremental_helper.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	dart/utils/apidoc/docgen.gyp	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/355563004/diff/40001/dart/site/try/src/Makefile File dart/site/try/src/Makefile (right): https://codereview.chromium.org/355563004/diff/40001/dart/site/try/src/Makefile#newcode6 dart/site/try/src/Makefile:6: PACKAGE_ROOT=../../../xcodebuild/ReleaseIA32/packages/ Is this a Mac-specific file (xcodebuild being ...

6 years, 6 months ago (2014-06-24 11:16:05 UTC) #2

ahe

Thank you, Johnni! https://codereview.chromium.org/355563004/diff/40001/dart/site/try/src/Makefile File dart/site/try/src/Makefile (right): https://codereview.chromium.org/355563004/diff/40001/dart/site/try/src/Makefile#newcode6 dart/site/try/src/Makefile:6: PACKAGE_ROOT=../../../xcodebuild/ReleaseIA32/packages/ On 2014/06/24 11:16:05, Johnni Winther ...

6 years, 6 months ago (2014-06-24 11:21:47 UTC) #3

ahe

Committed patchset #1 manually as r37653 (presubmit successful).

6 years, 6 months ago (2014-06-24 11:22:49 UTC) #4

Bob Nystrom

6 years, 6 months ago (2014-06-24 16:04:30 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/355563004/diff/40001/dart/pkg/dart2js_increme...
File dart/pkg/dart2js_incremental/pubspec.yaml (right):

https://codereview.chromium.org/355563004/diff/40001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/pubspec.yaml:6: version: 0.1
0.0.1 or 0.1.0. 0.1 isn't a valid semantic version.

Expand Messages | Collapse Messages