Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 3555021: Make JavaScript alert and confirm dialog boxes driveable by keyboard (Closed)

Created:
10 years, 2 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Make JavaScript alert and confirm dialog boxes driveable by keyboard. This regressed in r60785. An error during refactoring used -[JavaScriptAppModalDialogHelper textField] to determine whether an accessory view was added to a JavaScript dialog box, but this isn't a simple getter, and was allays returning true. BUG=58299 TEST=- javascript:alert("x") allows return keypress to dismiss dialog (OK); if FKA is on, allows space bar operation - javascript:confirm("x") allows return keypress to dismiss dialog (OK); if FKA is on, has focus on Cancel, is tabbable between Cancel and OK, and allows space bar operation; - javascript:prompt("x") focuses text field and allows return keypress to dismiss dialog (OK); if FKA is on, is tabbable between text field and buttons, and allows space bar operation on buttons - Note: FKA is Full Keyboard Access, from System Preferences:Keyboard Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/cocoa/js_modal_dialog_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
10 years, 2 months ago (2010-10-07 20:25:31 UTC) #1
Ben Goodger (Google)
10 years, 2 months ago (2010-10-07 20:27:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698