Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 355393004: [DevTools] Rename "emulateViewport" to "mobile". (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Rename "emulateViewport" to "mobile". BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177367

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : another rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -75 lines) Patch
M LayoutTests/inspector/device-emulation/device-emulation-partial.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/text-autosizing-override.html View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorClient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 11 chunks +20 lines, -20 lines 0 comments Download
M Source/devtools/front_end/Tests.js View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 2 12 chunks +14 lines, -15 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 7 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-06-30 12:49:52 UTC) #1
lushnikov
IMO 'emulateMobile' is clearer
6 years, 5 months ago (2014-06-30 12:52:01 UTC) #2
dgozman
On 2014/06/30 12:52:01, lushnikov wrote: > IMO 'emulateMobile' is clearer I don't think using "emulate" ...
6 years, 5 months ago (2014-06-30 13:47:44 UTC) #3
pfeldman
lgtm
6 years, 5 months ago (2014-06-30 13:50:47 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-06-30 19:20:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/355393004/1
6 years, 5 months ago (2014-06-30 19:21:11 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-06-30 20:10:21 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 20:11:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/10883) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/23330)
6 years, 5 months ago (2014-06-30 20:11:34 UTC) #9
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-01 13:47:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/355393004/20001
6 years, 5 months ago (2014-07-01 13:48:54 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-01 14:46:39 UTC) #12
dgozman
The CQ bit was unchecked by dgozman@chromium.org
6 years, 5 months ago (2014-07-01 14:47:27 UTC) #13
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-02 08:55:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/355393004/40001
6 years, 5 months ago (2014-07-02 08:56:01 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 10:06:30 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 12:55:11 UTC) #17
Message was sent while issue was closed.
Change committed as 177367

Powered by Google App Engine
This is Rietveld 408576698