Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 355373003: Simplify SVGTextQuery::modifyStartEndPositionsRespectingLigatures (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Simplify SVGTextQuery::modifyStartEndPositionsRespectingLigatures Simplify this method by passing it the fragment in question, and then use SVGTextFragment::metricsListOffset to get a reasonable starting point. Rewrite the big loop into two simpler loops - one for each end-point. This shaves another ~15% off the TC in the bug (on top of [1]). [1] https://codereview.chromium.org/359783002/ BUG=267504 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -57 lines) Patch
M Source/core/rendering/svg/SVGTextQuery.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextQuery.cpp View 2 chunks +22 lines, -56 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
Not a very easy-to-read diff I'm afraid...
6 years, 5 months ago (2014-06-30 10:34:11 UTC) #1
pdr.
On 2014/06/30 10:34:11, fs wrote: > Not a very easy-to-read diff I'm afraid... LGTM.
6 years, 5 months ago (2014-06-30 17:59:50 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-06-30 17:59:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/355373003/1
6 years, 5 months ago (2014-06-30 18:00:35 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 18:04:15 UTC) #5
Message was sent while issue was closed.
Change committed as 177231

Powered by Google App Engine
This is Rietveld 408576698