Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 355363002: Revert of Adds AL logging for Blink core events. (Closed)

Created:
6 years, 5 months ago by Timothy Loh
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, gavinp+prerender_chromium.org, watchdog-blink-watchlist_google.com, rwlbuis, felt
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Adds AL logging for Blink core events. (https://codereview.chromium.org/349263002/) Reason for revert: This is blocking the blink roll (https://codereview.chromium.org/346333005/) as it makes the test AdInjectionBrowserTest.DetectAdInjections in browser_tests fail Original issue's description: > Enables Activity Logger to log extension adding the following elements to the DOM: > - script > - link > - anchor > - iframe > - form > - input > - button > > BUG=388287 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177105 TBR=mvrable@chromium.org,haraken@chromium.org,pfeldman@chromium.org,pmarch@chromium.org NOTREECHECKS=true NOTRY=true BUG=388287 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177194

Patch Set 1 #

Patch Set 2 : manually fix conflict in Document.idl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -286 lines) Patch
M Source/core/dom/Document.idl View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Element.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 2 chunks +0 lines, -15 lines 0 comments Download
M Source/core/html/HTMLButtonElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 2 chunks +0 lines, -17 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 1 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 2 chunks +0 lines, -10 lines 0 comments Download
M Source/web/tests/ActivityLoggerTest.cpp View 1 4 chunks +5 lines, -187 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Timothy Loh
Created Revert of Adds AL logging for Blink core events.
6 years, 5 months ago (2014-06-30 07:10:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/355363002/1
6 years, 5 months ago (2014-06-30 07:11:42 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 07:11:49 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Document.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-06-30 07:11:50 UTC) #4
haraken
LGTM
6 years, 5 months ago (2014-06-30 07:12:44 UTC) #5
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 5 months ago (2014-06-30 07:25:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/355363002/20005
6 years, 5 months ago (2014-06-30 07:26:45 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 07:27:18 UTC) #8
Message was sent while issue was closed.
Change committed as 177194

Powered by Google App Engine
This is Rietveld 408576698