Issue 355343002: Harden a fullscreen transition test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355343002: Harden a fullscreen transition test (Closed)

Created:
6 years, 5 months ago by philipj_slow

Modified:
6 years, 5 months ago

Reviewers:
falken

CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Harden a fullscreen transition test Since the test uses only timeouts and no events, it passes even if the webkitRequestFullScreen() call fails, as it would e.g. if the webkitallowfullscreen attribute were simply removed. BUG=390008 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177196

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/355343002/1

6 years, 5 months ago (2014-06-30 08:27:21 UTC) #4

Message was sent while issue was closed.

Change committed as 177196

Expand Messages | Collapse Messages