Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 355293002: Remove pagination hacks in RenderLayerClipper::backgroundClipRect (Closed)

Created:
6 years, 5 months ago by abarth-chromium
Modified:
6 years, 5 months ago
Reviewers:
eseidel
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, chrishtr, eae+blinkwatch, esprehn, jchaffaix_chromium.org, jchaffraix+rendering, Julien - ping for review, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove pagination hacks in RenderLayerClipper::backgroundClipRect There's no reason we can't use the clip cache when there's an enclosing pagination layer. None of the rest of the code in RenderLayerClipper cares about paginations layers. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M Source/core/rendering/RenderLayerClipper.cpp View 1 chunk +4 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
abarth-chromium
6 years, 5 months ago (2014-06-27 22:26:18 UTC) #1
eseidel
I can't imagine this is particularly well tested. :(
6 years, 5 months ago (2014-06-27 22:58:25 UTC) #2
eseidel
lgtm
6 years, 5 months ago (2014-06-27 22:58:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/355293002/1
6 years, 5 months ago (2014-06-27 22:58:55 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 23:57:03 UTC) #5
Message was sent while issue was closed.
Change committed as 177155

Powered by Google App Engine
This is Rietveld 408576698