Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 355263002: Fixes another compile error when warnings are set (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fixes another compile error when warnings are set Or it may be just for arm, not sure which setting is triggering the compile error. BUG=none TEST=none R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282196

Patch Set 1 #

Total comments: 1

Patch Set 2 : conditional #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M mojo/examples/wget/wget.cc View 1 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
sky
6 years, 5 months ago (2014-06-27 20:10:01 UTC) #1
darin (slow to review)
https://codereview.chromium.org/355263002/diff/1/mojo/examples/wget/wget.cc File mojo/examples/wget/wget.cc (right): https://codereview.chromium.org/355263002/diff/1/mojo/examples/wget/wget.cc#newcode96 mojo/examples/wget/wget.cc:96: assert(num_bytes == fwrite(buf, num_bytes, 1, stdout)); doesn't assert(x) compile ...
6 years, 5 months ago (2014-06-28 05:29:00 UTC) #2
darin (slow to review)
6 years, 5 months ago (2014-06-28 05:29:02 UTC) #3
sky
Ugh, you're right. Will do another fix when I get back. -Scott On Fri, Jun ...
6 years, 5 months ago (2014-06-28 15:38:51 UTC) #4
sky
How about a printf as this isn't really expected?
6 years, 5 months ago (2014-07-09 20:56:25 UTC) #5
darin (slow to review)
https://codereview.chromium.org/355263002/diff/20001/mojo/examples/wget/wget.cc File mojo/examples/wget/wget.cc (right): https://codereview.chromium.org/355263002/diff/20001/mojo/examples/wget/wget.cc#newcode96 mojo/examples/wget/wget.cc:96: if (fwrite(buf, num_bytes, 1, stdout) != num_bytes) { LGTM
6 years, 5 months ago (2014-07-09 21:02:21 UTC) #6
sky
6 years, 5 months ago (2014-07-09 21:12:33 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 5 months ago (2014-07-09 21:12:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/355263002/20001
6 years, 5 months ago (2014-07-09 21:18:13 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 00:45:35 UTC) #10
Message was sent while issue was closed.
Change committed as 282196

Powered by Google App Engine
This is Rietveld 408576698