Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 355203007: Remove enterprise device user report size limit. (Closed)

Created:
6 years, 5 months ago by Steve Condie
Modified:
6 years, 5 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove enterprise device user report size limit. BUG=388465 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281789

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -33 lines) Patch
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 3 chunks +4 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Steve Condie
6 years, 5 months ago (2014-07-01 20:22:58 UTC) #1
Joao da Silva
lgtm, but why don't we remove the limit completely? https://codereview.chromium.org/355203007/diff/1/chrome/browser/chromeos/policy/device_status_collector.cc File chrome/browser/chromeos/policy/device_status_collector.cc (right): https://codereview.chromium.org/355203007/diff/1/chrome/browser/chromeos/policy/device_status_collector.cc#newcode451 chrome/browser/chromeos/policy/device_status_collector.cc:451: ...
6 years, 5 months ago (2014-07-07 09:43:23 UTC) #2
Steve Condie
On 2014/07/07 09:43:23, Joao da Silva wrote: > lgtm, but why don't we remove the ...
6 years, 5 months ago (2014-07-07 16:55:24 UTC) #3
Joao da Silva
lgtm
6 years, 5 months ago (2014-07-07 17:46:41 UTC) #4
Steve Condie
The CQ bit was checked by stepco@chromium.org
6 years, 5 months ago (2014-07-07 20:54:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/355203007/20001
6 years, 5 months ago (2014-07-07 20:55:09 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 00:03:49 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 00:35:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90362)
6 years, 5 months ago (2014-07-08 00:35:31 UTC) #9
Steve Condie
The CQ bit was checked by stepco@chromium.org
6 years, 5 months ago (2014-07-08 18:08:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stepco@chromium.org/355203007/20001
6 years, 5 months ago (2014-07-08 18:11:28 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 19:20:14 UTC) #12
Message was sent while issue was closed.
Change committed as 281789

Powered by Google App Engine
This is Rietveld 408576698