samplecode/SampleTextAlpha.cpp - Issue 355193006: stop calling SkCanvas::getDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleTextAlpha.cpp

Issue 355193006: stop calling SkCanvas::getDevice (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleTextAlpha.cpp

diff --git a/samplecode/SampleTextAlpha.cpp b/samplecode/SampleTextAlpha.cpp

index fcef92f3155da3ca580b5ed6233183e4813e2549..9b24887ed639e8a3bfaaa3ef681318fa6a1c200f 100644

--- a/samplecode/SampleTextAlpha.cpp

+++ b/samplecode/SampleTextAlpha.cpp

@@ -83,16 +83,6 @@ protected:

canvas->drawText(str, strlen(str), x, y, paint);

y += paint.getFontMetrics(NULL);

}

- if (false) { // avoid bit rot, suppress warning

- check_for_nonwhite(canvas->getDevice()->accessBitmap(false), fByte);

- SkDebugf("------ byte %x\n", fByte);

- }

- if (false) {

- fByte += 1;

- fByte &= 0xFF;

- this->inval(NULL);

- }

}

virtual SkView::Click* onFindClickHandler(SkScalar x, SkScalar y, unsigned) SK_OVERRIDE {