Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 355193006: stop calling SkCanvas::getDevice (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

stop calling SkCanvas::getDevice BUG=skia: Committed: https://skia.googlesource.com/skia/+/52d9ac6c92ddf33b3b05eb77ba9509a7aa441657

Patch Set 1 #

Patch Set 2 : fix gpu surface in writepixelstest #

Patch Set 3 : add guard for chrome and android #

Patch Set 4 : #

Total comments: 10

Patch Set 5 : address comments #

Patch Set 6 : remove unused function #

Patch Set 7 : guard gpu code in no-gpu build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -203 lines) Patch
M bench/DeferredSurfaceCopyBench.cpp View 1 chunk +2 lines, -17 lines 0 comments Download
M gm/srcmode.cpp View 1 chunk +11 lines, -8 lines 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 2 chunks +5 lines, -0 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 2 chunks +4 lines, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 7 chunks +8 lines, -31 lines 0 comments Download
M samplecode/SampleTextAlpha.cpp View 1 2 3 4 5 2 chunks +0 lines, -26 lines 0 comments Download
M src/animator/SkSnapshot.cpp View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 3 chunks +6 lines, -14 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 2 3 4 8 chunks +7 lines, -22 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 2 3 4 5 6 7 chunks +21 lines, -33 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 2 3 4 6 chunks +26 lines, -34 lines 0 comments Download
M tools/CopyTilesRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
reed1
in WritePixelsTest, I need to know how to create a gpu-surface, given those specifics around ...
6 years, 5 months ago (2014-06-27 21:17:28 UTC) #1
reed1
Juno, please look at my changes to DeferredCanvas
6 years, 5 months ago (2014-06-27 21:18:14 UTC) #2
bsalomon
On 2014/06/27 21:17:28, reed1 wrote: > in WritePixelsTest, I need to know how to create ...
6 years, 5 months ago (2014-06-27 21:26:13 UTC) #3
reed1
On 2014/06/27 21:26:13, bsalomon wrote: > On 2014/06/27 21:17:28, reed1 wrote: > > in WritePixelsTest, ...
6 years, 5 months ago (2014-06-28 01:00:34 UTC) #4
bsalomon
https://codereview.chromium.org/355193006/diff/60001/tests/ReadPixelsTest.cpp File tests/ReadPixelsTest.cpp (right): https://codereview.chromium.org/355193006/diff/60001/tests/ReadPixelsTest.cpp#newcode318 tests/ReadPixelsTest.cpp:318: surface.reset(SkSurface::NewScratchRenderTarget(context, info)); You don't need this line and line ...
6 years, 5 months ago (2014-06-30 13:24:33 UTC) #5
robertphillips
lgtm + naming nits https://codereview.chromium.org/355193006/diff/60001/src/utils/SkDeferredCanvas.cpp File src/utils/SkDeferredCanvas.cpp (right): https://codereview.chromium.org/355193006/diff/60001/src/utils/SkDeferredCanvas.cpp#newcode32 src/utils/SkDeferredCanvas.cpp:32: should_draw_immediately ? https://codereview.chromium.org/355193006/diff/60001/tests/DeferredCanvasTest.cpp File tests/DeferredCanvasTest.cpp ...
6 years, 5 months ago (2014-06-30 13:36:21 UTC) #6
reed1
https://codereview.chromium.org/355193006/diff/60001/src/utils/SkDeferredCanvas.cpp File src/utils/SkDeferredCanvas.cpp (right): https://codereview.chromium.org/355193006/diff/60001/src/utils/SkDeferredCanvas.cpp#newcode32 src/utils/SkDeferredCanvas.cpp:32: On 2014/06/30 13:36:20, robertphillips wrote: > should_draw_immediately ? Done. ...
6 years, 5 months ago (2014-06-30 14:33:12 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-06-30 14:37:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/355193006/80001
6 years, 5 months ago (2014-06-30 14:38:17 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-06-30 15:04:22 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 15:09:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/builds/1650)
6 years, 5 months ago (2014-06-30 15:09:33 UTC) #12
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-06-30 15:16:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/355193006/100001
6 years, 5 months ago (2014-06-30 15:16:22 UTC) #14
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-06-30 15:34:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/355193006/120001
6 years, 5 months ago (2014-06-30 15:34:09 UTC) #16
commit-bot: I haz the power
Change committed as 52d9ac6c92ddf33b3b05eb77ba9509a7aa441657
6 years, 5 months ago (2014-06-30 16:05:39 UTC) #17
Justin Novosad
6 years, 5 months ago (2014-07-02 14:24:25 UTC) #18
Message was sent while issue was closed. 
On 2014/06/30 16:05:39, I haz the power (commit-bot) wrote:
> Change committed as 52d9ac6c92ddf33b3b05eb77ba9509a7aa441657

Post-commit lgtm for the deferred canvas stuff (we were on holiday here)

Powered by Google App Engine
This is Rietveld 408576698