Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: Tools/GardeningServer/scripts/controllers.js

Issue 355193005: Remove checkout functionality from GOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/checkout_unittests.js ('k') | Tools/GardeningServer/scripts/model.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/controllers.js
diff --git a/Tools/GardeningServer/scripts/controllers.js b/Tools/GardeningServer/scripts/controllers.js
index 2d17970228b2992d3174db9e6bd2b7704a191262..3f2d63c1ed06d99004c289890143938e4d954a89 100644
--- a/Tools/GardeningServer/scripts/controllers.js
+++ b/Tools/GardeningServer/scripts/controllers.js
@@ -27,8 +27,6 @@ var controllers = controllers || {};
(function(){
-var kCheckoutUnavailableMessage = 'Failed! Garden-o-matic needs a local server to modify your working copy. Please run "webkit-patch garden-o-matic" start the local server.';
-
// FIXME: This is duplicated from ui/results.js :(.
function isAnyReftest(testName, resultsByTest)
{
@@ -48,12 +46,6 @@ function updateExpectationsWithStatusUpdates(failureInfoList)
var testNames = base.uniquifyArray(failureInfoList.map(function(failureInfo) { return failureInfo.testName; }));
var testName = testNames.length == 1 ? testNames[0] : testNames.length + ' tests';
statusView.addMessage(id, 'Updating expectations of ' + testName + '...');
-
- checkout.updateExpectations(failureInfoList, function() {
- statusView.addFinalMessage(id, 'Expectations update done! Please commit them locally and land with "git cl dcommit".');
- }, function() {
- statusView.addFinalMessage(id, kCheckoutUnavailableMessage);
- });
}
controllers.ResultsDetails = base.extends(Object, {
@@ -222,13 +214,6 @@ controllers.UnexpectedFailures = base.extends(FailureStreamController, {
{
return this._testFailures.length();
},
- onRollout: function(revision, testNameList)
- {
- checkout.rollout(revision, ui.rolloutReasonForTestNameList(testNameList)).then($.noop, function() {
- // FIXME: We should have a better error UI.
- alert(kCheckoutUnavailableMessage);
- });
- }
});
controllers.FailingBuilders = base.extends(Object, {
« no previous file with comments | « Tools/GardeningServer/scripts/checkout_unittests.js ('k') | Tools/GardeningServer/scripts/model.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698