Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: Source/build/scripts/name_macros.py

Issue 355193003: Qualify the bindings include files and remove the bindings sub-dirs from build files. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl » ('j') | Source/core/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/name_macros.py
diff --git a/Source/build/scripts/name_macros.py b/Source/build/scripts/name_macros.py
index a4f69a942dfe6125dce23d96a1a003e84d2bd42e..9af05b4131cee5d74c79b57c0de0d12ce7aded4a 100644
--- a/Source/build/scripts/name_macros.py
+++ b/Source/build/scripts/name_macros.py
@@ -131,8 +131,13 @@ class Writer(in_generator.Writer):
# Avoid duplicate includes.
if cpp_name in includes:
continue
- include = '#include "%(path)s"\n#include "V8%(script_name)s.h"' % {
+ if self.suffix == "Modules":
Nils Barth (inactive) 2014/06/30 02:19:52 nit: single quotes
c.shu 2014/06/30 19:46:07 Done.
+ subdir_name = 'modules'
+ else:
+ subdir_name = 'core'
+ include = '#include "%(path)s"\n#include "bindings/%(subdir_name)s/v8/V8%(script_name)s.h"' % {
'path': self._headers_header_include_path(entry),
+ 'subdir_name': subdir_name,
Nils Barth (inactive) 2014/06/30 02:19:52 nit: alpha
c.shu 2014/06/30 19:46:07 Done.
'script_name': name_utilities.script_name(entry),
}
includes[cpp_name] = self.wrap_with_condition(include, entry['Conditional'])
« no previous file with comments | « no previous file | Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl » ('j') | Source/core/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698