Issue 355193003: Qualify the bindings include files and remove the bindings sub-dirs from build files.

Issue 355193003: Qualify the bindings include files and remove the bindings sub-dirs from build files. (Closed)

Created:
6 years, 5 months ago by c.shu

Modified:
6 years, 5 months ago

Reviewers:
haraken, Nils Barth (inactive), tkent

CC:
blink-reviews, tzik, eric.carlson_apple.com, apavlov+blink_chromium.org, aandrey+blink_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, falken, devtools-reviews_chromium.org, loislo+blink_chromium.org, philipj_slow, nhiroki, eustas+blink_chromium.org, paulirish+reviews_chromium.org, lushnikov+blink_chromium.org, alecflett+watch_chromium.org, michaeln, feature-media-reviews_chromium.org, serviceworker-reviews, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Qualify the bindings include files and remove the bindings sub-dirs from build files. BUG=381876 TBR=tkent for web Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177160

Patch Set 1 #

Total comments: 6

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -26 lines)			Patch
M	Source/build/scripts/name_macros.py	View	1 chunk	+6 lines, -1 line	4 comments	Download
M	Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/build/scripts/templates/ElementWrapperFactory.h.tmpl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/BUILD.gn	View	1 chunk	+0 lines, -4 lines	2 comments	Download
M	Source/core/core.gyp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/modules/serviceworkers/RespondWithObserver.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/InspectorFrontendClientImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebBindings.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebBlob.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebDOMError.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebDOMFileSystem.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/web/WebDOMMediaStreamTrack.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebDevToolsFrontendImpl.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/web/tests/CustomEventTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/355193003/1

6 years, 5 months ago (2014-06-28 00:40:42 UTC) #4

Nils Barth (inactive)

Thanks Chang! 3 comments for cleanup in a follow-up CL. https://codereview.chromium.org/355193003/diff/1/Source/build/scripts/name_macros.py File Source/build/scripts/name_macros.py (right): https://codereview.chromium.org/355193003/diff/1/Source/build/scripts/name_macros.py#newcode134 ...

6 years, 5 months ago (2014-06-30 02:19:53 UTC) #6

c.shu

https://codereview.chromium.org/355193003/diff/1/Source/build/scripts/name_macros.py File Source/build/scripts/name_macros.py (right): https://codereview.chromium.org/355193003/diff/1/Source/build/scripts/name_macros.py#newcode134 Source/build/scripts/name_macros.py:134: if self.suffix == "Modules": On 2014/06/30 02:19:52, Nils Barth ...

6 years, 5 months ago (2014-06-30 19:46:07 UTC) #7

Nils Barth (inactive)

6 years, 5 months ago (2014-06-30 19:50:17 UTC) #8

Message was sent while issue was closed.

Thanks Chang!

For reference, the cleanup CL is:
Fix some nits as a follow-up for issue 355193003.
https://codereview.chromium.org/360053004/

Expand Messages | Collapse Messages