Issue 355183002: Disable speech synthesis API for content/ layer.

Issue 355183002: Disable speech synthesis API for content/ layer. (Closed)

Created:
6 years, 5 months ago by benm (inactive)

Modified:
6 years, 5 months ago

Reviewers:
dmazzoni, brettw

CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable speech synthesis API for content/ layer. The Speech Synthesis API relies on an implementation in chrome/ yet is a stable Web Platform feature so enabled in the content/ layer. Flip the enable flag to a disable flag, and set it for non-chrome content/ embedders. BUG=347045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280667

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -6 lines)			Patch
M	android_webview/lib/main/aw_main_delegate.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	content/child/runtime_features.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/shell/browser/shell_content_browser_client.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

benm (inactive)

On 2014/06/27 15:17:35, dmazzoni wrote: > +brettw for content OWNERS review ping for OWNERS review ...

6 years, 5 months ago (2014-06-30 10:25:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/355183002/1

6 years, 5 months ago (2014-06-30 17:24:33 UTC) #7

pfeldman

A revert of this CL has been created in https://codereview.chromium.org/359413005/ by pfeldman@chromium.org. The reason for ...

6 years, 5 months ago (2014-07-01 05:02:49 UTC) #9

benm (inactive)

6 years, 5 months ago (2014-07-01 12:43:54 UTC) #10

Message was sent while issue was closed.

On 2014/07/01 05:02:49, pfeldman wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/359413005/ by mailto:pfeldman@chromium.org.
> 
> The reason for reverting is: This breaks layout tests that are enumerating
> window properties:
> 
>  PASS window.cached_scrollbars.visible is false
> -PASS window.cached_speechSynthesis.onvoiceschanged is null
> -PASS window.cached_speechSynthesis.paused is false
> -PASS window.cached_speechSynthesis.pending is false
> -PASS window.cached_speechSynthesis.speaking is false
>  PASS window.cached_statusbar.visible is false
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...
> 
> .

Oh, hm. Darn...

I guess these tests are being run in content shell? Which seems a bit silly (for
some of them anyway) as speech synthesis doesn't work there...

Dominic - you mentioned that there was an effort to move the backend to
content/. Maybe it's better to just restart that rather than rebaslining all
these tests?

Expand Messages | Collapse Messages