Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 355163003: Don't prematurely delete script resources when registration is deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: redesign Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index aa0d43ba87c30022eaca087a0acd8af9abdf7830..84e61a93631e78cfd7c06fa64eb7d3791b52a6cc 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -389,12 +389,7 @@ void ServiceWorkerVersion::RemoveControllee(
RemoveProcessFromWorker(provider_host->process_id());
if (!HasControllee())
ScheduleStopWorker();
- // TODO(kinuko): Fire NoControllees notification when the # of controllees
- // reaches 0, so that a new pending version can be activated (which will
- // deactivate this version).
- // TODO(michaeln): On no controllees call storage DeleteVersionResources
- // if this version has been deactivated. Probably storage can listen for
- // NoControllees for versions that have been deleted.
+ FOR_EACH_OBSERVER(Listener, listeners_, OnNoControllees(this));
michaeln 2014/06/30 22:31:54 if (!HasControllee()) { ScheduleStopWorker( No
falken 2014/07/01 06:17:39 oops! Done
}
void ServiceWorkerVersion::AddWaitingControllee(

Powered by Google App Engine
This is Rietveld 408576698