content/browser/service_worker/service_worker_version.h - Issue 355163003: Don't prematurely delete script resources when registration is deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 355163003: Don't prematurely delete script resources when registration is deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_storage_unittest.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index f2fa3417bac485e7790f8186440591e7479e108b..bc5a31b8061d29d3b1031d9b8ff79112d12e08c8 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -74,20 +74,21 @@ class CONTENT_EXPORT ServiceWorkerVersion

class Listener {

public:

- virtual void OnWorkerStarted(ServiceWorkerVersion* version) = 0;

- virtual void OnWorkerStopped(ServiceWorkerVersion* version) = 0;

- virtual void OnVersionStateChanged(ServiceWorkerVersion* version) = 0;

+ virtual void OnWorkerStarted(ServiceWorkerVersion* version) {};

+ virtual void OnWorkerStopped(ServiceWorkerVersion* version) {};

+ virtual void OnVersionStateChanged(ServiceWorkerVersion* version) {};

virtual void OnErrorReported(ServiceWorkerVersion* version,

const base::string16& error_message,

int line_number,

int column_number,

- const GURL& source_url) = 0;

+ const GURL& source_url) {};

virtual void OnReportConsoleMessage(ServiceWorkerVersion* version,

int source_identifier,

int message_level,

const base::string16& message,

int line_number,

- const GURL& source_url) = 0;

+ const GURL& source_url) {};

+ virtual void OnNoControllees(ServiceWorkerVersion* version) {};

};

ServiceWorkerVersion(