content/browser/service_worker/service_worker_handle.h - Issue 355163003: Don't prematurely delete script resources when registration is deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_handle.h

Issue 355163003: Don't prematurely delete script resources when registration is deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_database_unittest.cc ('k') | content/browser/service_worker/service_worker_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_handle.h

diff --git a/content/browser/service_worker/service_worker_handle.h b/content/browser/service_worker/service_worker_handle.h

index 81d5b3574a242c62534508c2b2ed0764a58b5516..5b46b185ef5c011493215477129b6b74ea713a5c 100644

--- a/content/browser/service_worker/service_worker_handle.h

+++ b/content/browser/service_worker/service_worker_handle.h

@@ -28,7 +28,7 @@ class ServiceWorkerRegistration;

// ServiceWorkerRegistration (therefore they're guaranteed to be alive while

// this handle is around).

class CONTENT_EXPORT ServiceWorkerHandle

- : public ServiceWorkerVersion::Listener {

+ : NON_EXPORTED_BASE(public ServiceWorkerVersion::Listener) {

public:

// Creates a handle for a live version. The version's corresponding

// registration must be also alive.