Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Unified Diff: content/browser/service_worker/service_worker_database.h

Issue 355163003: Don't prematurely delete script resources when registration is deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: really fix win build Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_database.h
diff --git a/content/browser/service_worker/service_worker_database.h b/content/browser/service_worker/service_worker_database.h
index 6475de04a99e759663456c9224fb40f568eca388..c6124615c2ee5e3af3096c3bf3695a98e6eebac4 100644
--- a/content/browser/service_worker/service_worker_database.h
+++ b/content/browser/service_worker/service_worker_database.h
@@ -118,10 +118,10 @@ class CONTENT_EXPORT ServiceWorkerDatabase {
// - Bumps the next registration id and the next version id if needed.
// - Removes |resources| from the uncommitted list if exist.
// Returns OK they are successfully written. Otherwise, returns an error.
michaeln 2014/07/01 20:54:06 also describe the output params here
falken 2014/07/02 04:04:24 Done.
- Status WriteRegistration(
- const RegistrationData& registration,
- const std::vector<ResourceRecord>& resources,
- std::vector<int64>* newly_purgeable_resources);
+ Status WriteRegistration(const RegistrationData& registration,
+ const std::vector<ResourceRecord>& resources,
+ int64* deleted_version_id,
+ std::vector<int64>* newly_purgeable_resources);
// Updates a registration for |registration_id| to an active state. Returns OK
// if it's successfully updated. Otherwise, returns an error.
@@ -137,12 +137,14 @@ class CONTENT_EXPORT ServiceWorkerDatabase {
const base::Time& time);
// Deletes a registration for |registration_id| and moves resource records
- // associated with it into the purgeable list. Returns OK if it's successfully
- // deleted or not found in the database. Otherwise, returns an error.
- Status DeleteRegistration(
- int64 registration_id,
- const GURL& origin,
- std::vector<int64>* newly_purgeable_resources);
+ // associated with it into the purgeable list. Sets |version_id| to the
+ // id of the version that was stored and |newly_purgeable_resources| to its
michaeln 2014/07/01 20:54:06 'version that was deleted'
falken 2014/07/02 04:04:24 Done.
+ // resources. Returns OK if it's successfully deleted or not found in the
+ // database. Otherwise, returns an error.
+ Status DeleteRegistration(int64 registration_id,
+ const GURL& origin,
+ int64* version_id,
+ std::vector<int64>* newly_purgeable_resources);
// As new resources are put into the diskcache, they go into an uncommitted
// list. When a registration is saved that refers to those ids, they're

Powered by Google App Engine
This is Rietveld 408576698