Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: content/browser/service_worker/service_worker_storage_unittest.cc

Issue 355163003: Don't prematurely delete script resources when registration is deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_storage_unittest.cc
diff --git a/content/browser/service_worker/service_worker_storage_unittest.cc b/content/browser/service_worker/service_worker_storage_unittest.cc
index 417a0b7f237f2cb4ba7cc3dfc4273a272f6e1022..d5f13a30015201d68d791398767fe4341c0f3f9b 100644
--- a/content/browser/service_worker/service_worker_storage_unittest.cc
+++ b/content/browser/service_worker/service_worker_storage_unittest.cc
@@ -10,8 +10,10 @@
#include "content/browser/browser_thread_impl.h"
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_disk_cache.h"
+#include "content/browser/service_worker/service_worker_job_coordinator.h"
#include "content/browser/service_worker/service_worker_registration.h"
#include "content/browser/service_worker/service_worker_storage.h"
+#include "content/browser/service_worker/service_worker_test_utils.h"
#include "content/browser/service_worker/service_worker_version.h"
#include "content/common/service_worker/service_worker_status_code.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -547,14 +549,14 @@ TEST_F(ServiceWorkerStorageTest, ResourceIdsAreStoredAndPurged) {
base::RunLoop().RunUntilIdle();
ASSERT_TRUE(was_called);
EXPECT_EQ(SERVICE_WORKER_OK, result);
- EXPECT_EQ(2u, verify_ids.size());
+ EXPECT_EQ(0u, verify_ids.size());
verify_ids.clear();
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
storage()->database_->GetPurgeableResourceIds(&verify_ids));
EXPECT_TRUE(verify_ids.empty());
- EXPECT_FALSE(VerifyBasicResponse(storage(), kResourceId1, false));
- EXPECT_FALSE(VerifyBasicResponse(storage(), kResourceId2, false));
+ EXPECT_TRUE(VerifyBasicResponse(storage(), kResourceId1, false));
+ EXPECT_TRUE(VerifyBasicResponse(storage(), kResourceId2, false));
}
TEST_F(ServiceWorkerStorageTest, FindRegistration_LongestScopeMatch) {

Powered by Google App Engine
This is Rietveld 408576698