Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1572)

Unified Diff: content/browser/service_worker/service_worker_database_unittest.cc

Issue 355163003: Don't prematurely delete script resources when registration is deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_database_unittest.cc
diff --git a/content/browser/service_worker/service_worker_database_unittest.cc b/content/browser/service_worker/service_worker_database_unittest.cc
index baa2542cbc1b2d5ae272842f7e72352b86e12138..b22c69b10f46aeb7a121cd80cd6503f8b9aeeac6 100644
--- a/content/browser/service_worker/service_worker_database_unittest.cc
+++ b/content/browser/service_worker/service_worker_database_unittest.cc
@@ -254,8 +254,7 @@ TEST(ServiceWorkerDatabaseTest, GetOriginsWithRegistrations) {
// |origin3| has another registration, so should not remove it from the
// unique origin list.
ASSERT_EQ(ServiceWorkerDatabase::STATUS_OK,
- database->DeleteRegistration(data4.registration_id, origin3,
- &newly_purgeable_resources));
+ database->DeleteRegistration(data4.registration_id, origin3));
origins.clear();
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
@@ -267,8 +266,7 @@ TEST(ServiceWorkerDatabaseTest, GetOriginsWithRegistrations) {
// |origin3| should be removed from the unique origin list.
ASSERT_EQ(ServiceWorkerDatabase::STATUS_OK,
- database->DeleteRegistration(data3.registration_id, origin3,
- &newly_purgeable_resources));
+ database->DeleteRegistration(data3.registration_id, origin3));
origins.clear();
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
@@ -446,11 +444,7 @@ TEST(ServiceWorkerDatabaseTest, Registration_Basic) {
EXPECT_TRUE(uncommitted_ids_out.empty());
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
- database->DeleteRegistration(data.registration_id, origin,
- &newly_purgeable_resources));
- ASSERT_EQ(resources.size(), newly_purgeable_resources.size());
- for (size_t i = 0; i < resources.size(); ++i)
- EXPECT_EQ(newly_purgeable_resources[i], resources[i].resource_id);
+ database->DeleteRegistration(data.registration_id, origin));
// Make sure that the registration and resource records are gone.
resources_out.clear();
@@ -463,9 +457,7 @@ TEST(ServiceWorkerDatabaseTest, Registration_Basic) {
std::set<int64> purgeable_ids_out;
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
database->GetPurgeableResourceIds(&purgeable_ids_out));
- EXPECT_EQ(2u, purgeable_ids_out.size());
- EXPECT_TRUE(ContainsKey(purgeable_ids_out, resources[0].resource_id));
- EXPECT_TRUE(ContainsKey(purgeable_ids_out, resources[1].resource_id));
+ EXPECT_EQ(0U, purgeable_ids_out.size());
}
TEST(ServiceWorkerDatabaseTest, Registration_Overwrite) {
@@ -582,8 +574,7 @@ TEST(ServiceWorkerDatabaseTest, Registration_Multiple) {
// Delete registration1.
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
- database->DeleteRegistration(data1.registration_id, origin,
- &newly_purgeable_resources));
+ database->DeleteRegistration(data1.registration_id, origin));
// Make sure that registration1 is gone.
resources_out.clear();
@@ -595,9 +586,7 @@ TEST(ServiceWorkerDatabaseTest, Registration_Multiple) {
purgeable_ids_out.clear();
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
database->GetPurgeableResourceIds(&purgeable_ids_out));
- EXPECT_EQ(2u, purgeable_ids_out.size());
- EXPECT_TRUE(ContainsKey(purgeable_ids_out, resources1[0].resource_id));
- EXPECT_TRUE(ContainsKey(purgeable_ids_out, resources1[1].resource_id));
+ EXPECT_EQ(0u, purgeable_ids_out.size());
// Make sure that registration2 is still alive.
resources_out.clear();
@@ -653,8 +642,7 @@ TEST(ServiceWorkerDatabaseTest, UpdateVersionToActive) {
// Delete the registration.
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
- database->DeleteRegistration(data.registration_id, origin,
- &newly_purgeable_resources));
+ database->DeleteRegistration(data.registration_id, origin));
// Should be false because the registration is gone.
EXPECT_EQ(ServiceWorkerDatabase::STATUS_ERROR_NOT_FOUND,
@@ -708,8 +696,7 @@ TEST(ServiceWorkerDatabaseTest, UpdateLastCheckTime) {
// Delete the registration.
EXPECT_EQ(ServiceWorkerDatabase::STATUS_OK,
- database->DeleteRegistration(data.registration_id, origin,
- &newly_purgeable_resources));
+ database->DeleteRegistration(data.registration_id, origin));
// Should be false because the registration is gone.
EXPECT_EQ(ServiceWorkerDatabase::STATUS_ERROR_NOT_FOUND,

Powered by Google App Engine
This is Rietveld 408576698