Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 355163002: ServiceWorker: Update worker state when waitUntil rejected. (Closed)

Created:
6 years, 5 months ago by xiang
Modified:
6 years, 5 months ago
Reviewers:
falken, kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Update worker state when waitUntil be rejected. When "install" and "activate" events lifetime be extended by using waitUntil() method, the rejection of passing promise will update worker state to "redundant". See http://slightlyoff.github.io/ServiceWorker/spec/service_worker/ [[Install]] and [[Activate]] algorithms. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280997

Patch Set 1 #

Patch Set 2 : rename deactivated event #

Patch Set 3 : split the rename patch #

Patch Set 4 : add myself to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
xiang
PTAL, thanks.
6 years, 5 months ago (2014-06-27 12:15:29 UTC) #1
falken
On 2014/06/27 12:15:29, xiang wrote: > PTAL, thanks. This looks right, but can you write ...
6 years, 5 months ago (2014-06-30 01:59:03 UTC) #2
xiang
On 2014/06/30 01:59:03, falken wrote: > On 2014/06/27 12:15:29, xiang wrote: > > PTAL, thanks. ...
6 years, 5 months ago (2014-06-30 03:01:28 UTC) #3
falken
On 2014/06/30 03:01:28, xiang wrote: > On 2014/06/30 01:59:03, falken wrote: > > On 2014/06/27 ...
6 years, 5 months ago (2014-06-30 04:40:54 UTC) #4
xiang
On 2014/06/30 04:40:54, falken wrote: > On 2014/06/30 03:01:28, xiang wrote: > > On 2014/06/30 ...
6 years, 5 months ago (2014-07-01 06:26:14 UTC) #5
xiang
On 2014/07/01 06:26:14, xiang wrote: > On 2014/06/30 04:40:54, falken wrote: > > On 2014/06/30 ...
6 years, 5 months ago (2014-07-02 08:18:56 UTC) #6
falken
On 2014/07/02 08:18:56, xiang wrote: > On 2014/07/01 06:26:14, xiang wrote: > > On 2014/06/30 ...
6 years, 5 months ago (2014-07-02 08:24:03 UTC) #7
xiang
The CQ bit was checked by xiang.long@intel.com
6 years, 5 months ago (2014-07-02 08:30:31 UTC) #8
xiang
The CQ bit was unchecked by xiang.long@intel.com
6 years, 5 months ago (2014-07-02 08:30:52 UTC) #9
xiang
The CQ bit was checked by xiang.long@intel.com
6 years, 5 months ago (2014-07-02 08:48:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiang.long@intel.com/355163002/60001
6 years, 5 months ago (2014-07-02 08:50:06 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 10:49:22 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 10:56:30 UTC) #13
Message was sent while issue was closed.
Change committed as 280997

Powered by Google App Engine
This is Rietveld 408576698