chrome/browser/password_manager/password_store_factory.cc - Issue 355143006: [Password Manager] Add UMA stats to track interaction with synced accounts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_factory.cc

Issue 355143006: [Password Manager] Add UMA stats to track interaction with synced accounts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Typo Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/mock_password_store_service.cc ('k') | chrome/browser/password_manager/password_store_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_factory.cc

diff --git a/chrome/browser/password_manager/password_store_factory.cc b/chrome/browser/password_manager/password_store_factory.cc

index 1db6e65eb69ae2b99b9cf7dbd9cfde47303793af..997ba9e3d2f8515e3117983ba88e49031c799d0e 100644

--- a/chrome/browser/password_manager/password_store_factory.cc

+++ b/chrome/browser/password_manager/password_store_factory.cc

@@ -7,6 +7,7 @@

#include "base/command_line.h"

#include "base/environment.h"

#include "base/prefs/pref_service.h"

+#include "chrome/browser/password_manager/sync_metrics.h"

#include "chrome/browser/profiles/incognito_helpers.h"

#include "chrome/browser/sync/glue/sync_start_util.h"

#include "chrome/browser/webdata/web_data_service.h"

@@ -225,8 +226,11 @@ KeyedService* PasswordStoreFactory::BuildServiceInstanceFor(

#else

NOTIMPLEMENTED();

#endif

+ std::string sync_username =

+ password_manager_sync_metrics::GetPasswordSyncUsername(profile);

if (!ps || !ps->Init(

- sync_start_util::GetFlareForSyncableService(profile->GetPath()))) {

+ sync_start_util::GetFlareForSyncableService(profile->GetPath()),

+ sync_username)) {

NOTREACHED() << "Could not initialize password manager.";

return NULL;

}