[Password Manager] Add UMA stats to track interaction with synced accounts.

components/password_manager/core/browser/login_database.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/login_database.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/pickle.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
 #include "components/autofill/core/common/password_form.h"
+#include "google_apis/gaia/gaia_auth_util.h"
+#include "google_apis/gaia/gaia_urls.h"
 #include "sql/connection.h"
 #include "sql/statement.h"
 #include "sql/transaction.h"
 
 using autofill::PasswordForm;
 
 namespace password_manager {
 
 static const int kCurrentVersionNumber = 6;
 static const int kCompatibleVersionNumber = 1;
@@ skipping 219 matching lines @@
     }
     if (!db_.Execute("CREATE INDEX logins_signon ON "
                      "logins (signon_realm)")) {
       NOTREACHED();
       return false;
     }
   }
   return true;
 }
 
-void LoginDatabase::ReportMetrics() {
+void LoginDatabase::ReportMetrics(const std::string& sync_username) {
   sql::Statement s(db_.GetCachedStatement(
       SQL_FROM_HERE,
       "SELECT signon_realm, blacklisted_by_user, COUNT(username_value) "
       "FROM logins GROUP BY signon_realm, blacklisted_by_user"));
 
   if (!s.is_valid())
     return;
 
   int total_accounts = 0;
   int blacklisted_sites = 0;
@@ skipping 27 matching lines @@
     if (type == PasswordForm::TYPE_GENERATED) {
       UMA_HISTOGRAM_CUSTOM_COUNTS(
           "PasswordManager.TimesGeneratedPasswordUsed",
           usage_statement.ColumnInt(1), 0, 100, 10);
     } else {
       UMA_HISTOGRAM_CUSTOM_COUNTS(
           "PasswordManager.TimesPasswordUsed",
           usage_statement.ColumnInt(1), 0, 100, 10);
     }
   }
+
+  bool syncing_account_saved = false;
+  if (!sync_username.empty()) {
+    sql::Statement sync_statement(db_.GetCachedStatement(
+        SQL_FROM_HERE,
+        "SELECT username_value FROM logins "
+        "WHERE signon_realm == ?"));
+    sync_statement.BindString(
+        0, GaiaUrls::GetInstance()->gaia_url().GetOrigin().spec());
+
+    if (!sync_statement.is_valid())
+      return;
+
+    while (sync_statement.Step()) {
+      std::string username = sync_statement.ColumnString(0);
+      if (gaia::AreEmailsSame(sync_username, username)) {
+        syncing_account_saved = true;
+        break;
+      }
+    }
+  }
+  UMA_HISTOGRAM_ENUMERATION("PasswordManager.SyncingAccountState",
+                            2 * sync_username.empty() + syncing_account_saved,

[vabr (Chromium), 2014/07/01 08:52:00]

This type of boolean mixing arithmetic looks almost like a cryptic riddle to me,
but the C++ norm does guarantee [1] that true converts to 1, and not just to any
non-zero number, so I'm fine with that. :)

[1] §4.7/4 from the C++ Standard
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3337.pdf

[Garrett Casto, 2014/07/04 07:27:49]

Yeah, verified this with the standard before I used it :). I do this in testing
code all the time but I wasn't actually certain it was guaranteed.

+                            4);
 }
 
 PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) {
   PasswordStoreChangeList list;
   std::string encrypted_password;
   if (EncryptedString(form.password_value, &encrypted_password) !=
           ENCRYPTION_RESULT_SUCCESS)
     return list;
 
   // You *must* change LoginTableColumns if this query changes.
@@ skipping 374 matching lines @@
 
 bool LoginDatabase::DeleteAndRecreateDatabaseFile() {
   DCHECK(db_.is_open());
   meta_table_.Reset();
   db_.Close();
   sql::Connection::Delete(db_path_);
   return Init(db_path_);
 }
 
 }  // namespace password_manager