Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: pkg/polymer_expressions/test/bindings_test.dart

Issue 355133002: switch Node.bind to interop (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer_expressions/pubspec.yaml ('k') | pkg/polymer_expressions/test/bindings_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer_expressions/test/bindings_test.dart
diff --git a/pkg/polymer_expressions/test/bindings_test.dart b/pkg/polymer_expressions/test/bindings_test.dart
index 571b473ef4f2a08e199e64a8f67d848be9bfc99f..c5469ba95569dfbd52d65eae65664fee68e25966 100644
--- a/pkg/polymer_expressions/test/bindings_test.dart
+++ b/pkg/polymer_expressions/test/bindings_test.dart
@@ -157,10 +157,6 @@ main() => dirtyCheckZone().run(() {
});
});
- // TODO(sigmund): enable this test (issue 19105)
- // _cursorPositionTest(false);
- _cursorPositionTest(true);
-
// Regression tests for issue 18792.
for (var usePolymer in [true, false]) {
// We run these tests both with PolymerExpressions and with the default
@@ -171,6 +167,10 @@ main() => dirtyCheckZone().run(() {
// Use <option template repeat="{{y}}" value="{{}}">item {{}}
_initialSelectTest('{{y}}', '{{}}', usePolymer);
_updateSelectTest('{{y}}', '{{}}', usePolymer);
+
+ // TODO(jmesserly): this is broken with polymer-expressions, see
+ // http://dartbug.com/19105
+ if (!usePolymer) _cursorPositionTest(usePolymer);
});
}
@@ -210,7 +210,7 @@ _cursorPositionTest(bool usePolymer) {
expect(el.selectionEnd, 3);
el.value = 'abc de';
- // Updating the input value programatically (even to the same value in
+ // Updating the input value programmatically (even to the same value in
// Chrome) loses the selection position.
expect(el.selectionStart, 6);
expect(el.selectionEnd, 6);
« no previous file with comments | « pkg/polymer_expressions/pubspec.yaml ('k') | pkg/polymer_expressions/test/bindings_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698