pkg/observe/lib/src/bindable.dart - Issue 355133002: switch Node.bind to interop

Unified Diff: pkg/observe/lib/src/bindable.dart

Issue 355133002: switch Node.bind to interop (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/observe/lib/src/bindable.dart

diff --git a/pkg/observe/lib/src/bindable.dart b/pkg/observe/lib/src/bindable.dart

index 4b628a60b82e3931ec67ecba50986bc090ac5e55..97653e5a18a38d8cdae6172f4ef1c954768ff7ce 100644

--- a/pkg/observe/lib/src/bindable.dart

+++ b/pkg/observe/lib/src/bindable.dart

@@ -34,4 +34,8 @@ abstract class Bindable {

/// Note: setting the value of a [Bindable] must not call the [callback] with

/// the new value. Any pending change notifications must be discarded.

set value(newValue) {}

+ /// Deliver changes. Typically this will perform dirty-checking, if any is

+ /// needed.

+ deliver() => null;

Siggi Cherem (dart-lang) 2014/06/27 18:40:53 deliver(); (since the class is anyways abstract)

Jennifer Messerly 2014/06/27 19:10:04 thought about that, but then it would be a breakin

Siggi Cherem (dart-lang) 2014/06/27 19:22:45 sgtm, not sure what the return value means, but if

Jennifer Messerly 2014/06/27 21:03:37 yeah, it's confusing. I went ahead and removed the

}