switch Node.bind to interop

pkg/template_binding/test/template_binding_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library template_binding.test.template_binding_test;
 
 import 'dart:async';
 import 'dart:html';
 import 'dart:js' show JsObject;
 import 'dart:math' as math;
@@ skipping 150 matching lines @@
     // Dart note: predicate changed from 0->null because 0 isn't falsey in Dart.
     // See https://code.google.com/p/dart/issues/detail?id=11956
     // Changed bound from null->1 since null is equivalent to JS undefined,
     // and would cause the template to not be expanded.
     var m = toObservable({ 'predicate': null, 'bound': 1 });
     var template = div.firstChild;
     bool errorSeen = false;
     runZoned(() {
       templateBind(template).model = m;
     }, onError: (e, s) {
-      expect(e, isNoSuchMethodError);
+      _expectNoSuchMethod(e);
       errorSeen = true;
     });
     return new Future(() {
       expect(div.nodes.length, 1);
 
       m['predicate'] = 1;
 
       expect(errorSeen, isFalse);
     }).then(nextMicrotask).then((_) {
       expect(errorSeen, isTrue);
@@ skipping 63 matching lines @@
         '</template>');
 
     // Dart note: changed bound from null->1 since null is equivalent to JS
     // undefined, and would cause the template to not be expanded.
     var m = toObservable({ 'predicate': 1, 'bound': 1 });
     var template = div.firstChild;
     bool errorSeen = false;
     runZoned(() {
       templateBind(template).model = m;
     }, onError: (e, s) {
-      expect(e, isNoSuchMethodError);
+      _expectNoSuchMethod(e);
       errorSeen = true;
     });
 
     return new Future(() {
       expect(div.nodes.length, 1);
       m['bound'] = toObservable({ 'value': 2 });
       expect(errorSeen, isTrue);
     }).then(endOfMicrotask).then((_) {
       expect(div.nodes.length, 2);
       expect(div.lastChild.text, 'value:2');
@@ skipping 2103 matching lines @@
     expect(instance.firstChild.nextNode.text, 'bar:replaced');
 
     clearAllTemplates(instance);
   });
 
   test('CreateInstance - sync error', () {
     var div = createTestHtml('<template>{{foo}}</template>');
     var outer = templateBind(div.nodes.first);
     var model = 1; // model is missing 'foo' should throw.
     expect(() => outer.createInstance(model, new TestBindingSyntax()),
-        throwsA(isNoSuchMethodError));
+        throwsA(_isNoSuchMethodError));
   });
 
   test('CreateInstance - async error', () {
     var div = createTestHtml(
       '<template>'
         '<template bind="{{b}}">'
           '{{ foo }}:{{ replaceme }}'
         '</template>'
       '</template>');
     var outer = templateBind(div.nodes.first);
     var model = toObservable({'b': 1}); // missing 'foo' should throw.
 
     bool seen = false;
     runZoned(() => outer.createInstance(model, new TestBindingSyntax()),
       onError: (e) {
-        expect(e, isNoSuchMethodError);
+        _expectNoSuchMethod(e);
         seen = true;
       });
     return new Future(() { expect(seen, isTrue); });
   });
 
   test('Repeat - svg', () {
     var div = createTestHtml(
         '<svg width="400" height="110">'
           '<template repeat>'
             '<rect width="{{ width }}" height="{{ height }}" />'
@@ skipping 180 matching lines @@
 
       var a = img.nextNode;
       expect(a.attributes['href'], 'link.html');
 
       var input = a.nextNode;
       expect(input.value, '4');
     });
   });
 }
 
+// TODO(jmesserly): ideally we could test the type with isNoSuchMethodError,
+// however dart:js converts the nSM into a String at some point.
+// So for now we do string comparison.
+_isNoSuchMethodError(e) => '$e'.contains('NoSuchMethodError');

[Jennifer Messerly, 2014/06/27 01:07:25]

I still need to make a repro for this bug and file it.

Basically, given a call order like Dart -> JS -> Dart (which throws nSM) ... we
are not getting an Exception in Dart out of the other side. It ends up a string.

[Siggi Cherem (dart-lang), 2014/06/27 18:40:52]

yikes!

[Jennifer Messerly, 2014/06/27 19:10:03]

yeah :(

I actually didn't try it on dart2js ... it might only be a Dartium issue. Needs
more investigation.

+
+_expectNoSuchMethod(e) {
+  // expect(e, isNoSuchMethodError);
+  expect('$e', contains('NoSuchMethodError'));
+}
+
 class Issue285Syntax extends BindingDelegate {
   prepareInstanceModel(template) {
     if (template.id == 'del') return (val) => val * 2;
   }
 }
 
 class TestBindingSyntax extends BindingDelegate {
   prepareBinding(String path, name, node) {
     if (path.trim() == 'replaceme') {
       return (m, n, oneTime) => new PathObserver('replaced', '');
@@ skipping 28 matching lines @@
 class TestAccessorModel extends Observable {
   @observable var value = 1;
   var count = 0;
 
   @reflectable
   get prop {
     count++;
     return value;
   }
 }