Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 355093003: [sql] Test recovery of corrupt golden file. (Closed)

Created:
6 years, 6 months ago by Scott Hess - ex-Googler
Modified:
6 years, 5 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[sql] Test recovery of corrupt golden file. Manually modify a SQLite database to have the problem described by the bug, then test that it can be recovered. Also, infrastructure to introduce testing data to sql/ tests. BUG=387868 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282197

Patch Set 1 #

Patch Set 2 : Cleanup gyp file, BUILD.gn change. #

Patch Set 3 : Rebase to catch landed binary #

Patch Set 4 : Best guess at gn fix. #

Patch Set 5 : Add sql.isolate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -15 lines) Patch
M build/android/pylib/gtest/setup.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M sql/BUILD.gn View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M sql/recovery_unittest.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M sql/sql.gyp View 1 2 3 4 3 chunks +23 lines, -1 line 0 comments Download
A + sql/sql_unittests.isolate View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
A sql/test/paths.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + sql/test/paths.cc View 3 chunks +11 lines, -7 lines 0 comments Download
A + sql/test/run_all_unittests.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A sql/test/sql_test_suite.h View 1 chunk +29 lines, -0 lines 0 comments Download
A sql/test/sql_test_suite.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Scott Hess - ex-Googler
This manages to fail on ASAN with the noted bug, while succeeding when https://codereview.chromium.org/343423004/ is ...
6 years, 6 months ago (2014-06-26 18:27:44 UTC) #1
Scott Hess - ex-Googler
On 2014/06/26 18:27:44, shess wrote: > Occurs to me that I should convert sql.gyp to ...
6 years, 6 months ago (2014-06-26 20:20:03 UTC) #2
Scott Hess - ex-Googler
ping?
6 years, 5 months ago (2014-07-07 21:14:57 UTC) #3
michaeln
lgtm
6 years, 5 months ago (2014-07-07 21:28:45 UTC) #4
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 5 months ago (2014-07-08 19:35:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/355093003/40001
6 years, 5 months ago (2014-07-08 19:38:10 UTC) #6
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 5 months ago (2014-07-08 20:22:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/355093003/60001
6 years, 5 months ago (2014-07-08 20:25:43 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 00:42:03 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 01:00:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/169093)
6 years, 5 months ago (2014-07-09 01:00:29 UTC) #11
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 5 months ago (2014-07-09 19:32:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/355093003/80001
6 years, 5 months ago (2014-07-09 19:35:30 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 22:18:38 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 00:48:09 UTC) #15
Message was sent while issue was closed.
Change committed as 282197

Powered by Google App Engine
This is Rietveld 408576698