sync/api/attachments/attachment_downloader.h - Issue 355093002: Consolidate attachment URL construction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/attachment_downloader.h

Issue 355093002: Consolidate attachment URL construction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move static method declaration and definition. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/api/attachments/attachment_downloader.h

diff --git a/sync/api/attachments/attachment_downloader.h b/sync/api/attachments/attachment_downloader.h

index 718284cc930cd4f2e711fddacea83e9704e63326..b2b2037fc7c53af699a83072bd402711fdaedf0f 100644

--- a/sync/api/attachments/attachment_downloader.h

+++ b/sync/api/attachments/attachment_downloader.h

@@ -41,8 +41,7 @@ class SYNC_EXPORT AttachmentDownloader {

const DownloadCallback& callback) = 0;

// Create instance of AttachmentDownloaderImpl.

- // |url_prefix| is the URL prefix (including trailing slash) to be used when

- // downloading attachments.

+ // |sync_service_url| is the URL of the sync service.

// |url_request_context_getter| provides a URLRequestContext.

@@ -52,7 +51,7 @@ class SYNC_EXPORT AttachmentDownloader {

// |token_service_provider| provides an OAuth2 token service.

static scoped_ptr<AttachmentDownloader> Create(

- const std::string& url_prefix,

+ const GURL& sync_service_url,

const scoped_refptr<net::URLRequestContextGetter>&

url_request_context_getter,

const std::string& account_id,