LayoutTests/loader/data-uri-images-load-when-loading-images-automatically-disabled.html - Issue 355043002: Fix loading of data: URI images wrt loadsImagesAutomatically setting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/loader/data-uri-images-load-when-loading-images-automatically-disabled.html

Issue 355043002: Fix loading of data: URI images wrt loadsImagesAutomatically setting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/loader/data-uri-images-load-when-loading-images-automatically-disabled-expected.txt » ('j') | Source/core/fetch/ResourceFetcher.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 data:uri images should load if loadsImagesAutomatically is disabled<br/>

	5 <script>

	6 if (window.testRunner) {

	7 testRunner.waitUntilDone();
	eseidel 2014/06/26 16:24:35 You shouldn't have to wait until done? onload won You shouldn't have to wait until done? onload won't be sent until all subresources are loaded... We don't dump until onload is sent. mnaganov (inactive) 2014/06/26 16:42:40 Thanks for the tip! Indeed, this isn't needed. Show quoted text On 2014/06/26 16:24:35, eseidel wrote: > You shouldn't have to wait until done? onload won't be sent until all > subresources are loaded... We don't dump until onload is sent. Thanks for the tip! Indeed, this isn't needed.
	8 testRunner.dumpAsText();

	9 }

	10 if (window.internals)

	11 internals.settings.setLoadsImagesAutomatically(false);

	12 function imageLoaded() {

	13 document.write("PASS");

	14 if (window.testRunner)

	15 testRunner.notifyDone();

	16 }

	17 function timeout() {

	18 document.write("FAIL");

	19 if (window.testRunner)

	20 testRunner.notifyDone();

	21 }

	22 setTimeout(timeout, 15000);
	eseidel 2014/06/26 16:24:35 You souldn't need this. content_shell knows how t You souldn't need this. content_shell knows how to time out itself. :) I would set this to way smaller if you want to have your own timeout. Also, I think images have an onerror handler you could use instead. mnaganov (inactive) 2014/06/26 16:42:40 Removed the timeout. I can't use onerror because l Show quoted text On 2014/06/26 16:24:35, eseidel wrote: > You souldn't need this. content_shell knows how to time out itself. :) I would > set this to way smaller if you want to have your own timeout. Also, I think > images have an onerror handler you could use instead. Removed the timeout. I can't use onerror because loadsImagesAutomatically doesn't forbid loading images, it just defers loading. Anyway, the test now prints "PASS" on success, or leaves a message I have added as a default body text.
	23 </script>

	24 <img onload="imageLoaded()" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAA GQAAABkCAIAAAD/gAIDAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAnklEQVR42u3QMQEAAAgDoGlyo1vBz wciUJlw1ApkyZIlS5YsBbJkyZIlS5YCWbJkyZIlS4EsWbJkyZKlQJYsWbJkyVIgS5YsWbJkKZAlS5YsW bIUyJIlS5YsWQpkyZIlS5YsBbJkyZIlS5YCWbJkyZIlS4EsWbJkyZKlQJYsWbJkyVIgS5YsWbJkKZAlS 5YsWbIUyJIlS5YsWQpkyfq2MosBSIeKONMAAAAASUVORK5CYII=">

	25 </body>

	26 </html>

OLD	NEW