Chromium Code Reviews
Help | Chromium Project | Sign in
(611)

Issue 355028: Disk Cache: New interface that enables asynchronous completion... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by rvargas
Modified:
4 years, 1 month ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com, darin (slow to review), PaweĊ‚ Hajdan Jr., michaeln
Visibility:
Public.

Description

Disk Cache: New interface that enables asynchronous completion of any operation that may block. BUG=26730 TEST=none

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 20

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -6 lines) Patch
M net/disk_cache/backend_impl.h View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 2 3 6 chunks +49 lines, -0 lines 0 comments Download
M net/disk_cache/disk_cache.h View 1 2 3 11 chunks +103 lines, -6 lines 0 comments Download
M net/disk_cache/entry_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/disk_cache/mem_backend_impl.h View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M net/disk_cache/mem_backend_impl.cc View 1 2 3 7 chunks +49 lines, -0 lines 0 comments Download
M net/disk_cache/mem_entry_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/disk_cache/mem_entry_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 3 4 chunks +35 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
rvargas
5 years, 8 months ago (2009-11-04 21:57:41 UTC) #1
wtc
LGTM. Please at least change typedef=>using and move |callback| to be the last parameter before ...
5 years, 8 months ago (2009-11-05 18:57:35 UTC) #2
rvargas
Thanks for the review. I'll wait for your comments. http://codereview.chromium.org/355028/diff/1020/1026 File net/disk_cache/backend_impl.cc (right): http://codereview.chromium.org/355028/diff/1020/1026#newcode388 Line ...
5 years, 8 months ago (2009-11-05 19:29:11 UTC) #3
wtc
http://codereview.chromium.org/355028/diff/1020/1028 File net/disk_cache/disk_cache.h (right): http://codereview.chromium.org/355028/diff/1020/1028#newcode66 Line 66: bool force, CompletionCallback* callback, On 2009/11/05 19:29:12, rvargas ...
5 years, 8 months ago (2009-11-05 20:22:27 UTC) #4
rvargas
Thanks. http://codereview.chromium.org/355028/diff/1020/1028 File net/disk_cache/disk_cache.h (right): http://codereview.chromium.org/355028/diff/1020/1028#newcode166 Line 166: // changing its value. This method returns ...
5 years, 8 months ago (2009-11-05 20:57:32 UTC) #5
wtc
5 years, 8 months ago (2009-11-05 21:54:52 UTC) #6
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5