Issue 35493002: Update Channel ID API to use a callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 35493002: Update Channel ID API to use a callback. (Closed)

Created:
7 years, 2 months ago by qsr

Modified:
7 years, 2 months ago

Reviewers:
agl, Ryan Sleevi

Base URL:
https://chromium.googlesource.com/chromium/deps/openssl.git@master

Visibility:
Public.

Update Channel ID API to use a callback. R=agl@chromium.org, rsleevi@chromium.org Committed: 230363

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -38 lines)			Patch
M	import_from_android.sh	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	openssl/include/openssl/ssl.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	openssl/ssl/s3_clnt.c	View	1	1 chunk	+15 lines, -6 lines	0 comments	Download
M	openssl/ssl/ssl.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	openssl/ssl/ssl_sess.c	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	patches.chromium/channelid.patch	View	1	12 chunks	+98 lines, -30 lines	0 comments	Download

Total messages: 4 (0 generated)

Ryan Sleevi

Add the BUG # Otherwise LGTM. There's a slight subtlety in that this API conflates ...

7 years, 2 months ago (2013-10-22 19:54:59 UTC) #2

agl

LGTM. There can't be a "ChannelID not available" case because, once the extensions have been ...

7 years, 2 months ago (2013-10-22 20:00:16 UTC) #3

qsr

7 years, 2 months ago (2013-10-23 07:40:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r230363 (presubmit successful).