Issue 354913004: Fix RRect transform bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354913004: Fix RRect transform bug (Closed)

Created:
6 years, 5 months ago by robertphillips

Modified:
6 years, 5 months ago

Reviewers:
caryclark

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix RRect tranform bug When a RRect is an oval transforming the rectangle and the radii separately can result in a non-oval result (i.e., due to numerical issues some tiny straight edges may creep in). This CL remedies the situation by computing the new radii directly from the transformed rect. BUG=skia:2696 Committed: https://skia.googlesource.com/skia/+/e5c1e3cd63e22bb06c24dd051f4d814f24786c08

Patch Set 1 #

Patch Set 2 : Add unit test #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -4 lines)			Patch
	M	src/core/SkRRect.cpp	View		2 chunks	+13 lines, -4 lines	0 comments	Download
	M	tests/RoundRectTest.cpp	View	1	2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 5 months ago (2014-06-27 15:47:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/354913004/20001

6 years, 5 months ago (2014-06-27 15:48:14 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-06-27 15:59:30 UTC) #5

Message was sent while issue was closed.

Change committed as e5c1e3cd63e22bb06c24dd051f4d814f24786c08

Expand Messages | Collapse Messages