Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/opus/opus.gyp

Issue 354903003: Enable FIXED_POINT and -O3 for Opus when building for ARM (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restrict -O3 flag to arm Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/opus/opus.gyp
diff --git a/third_party/opus/opus.gyp b/third_party/opus/opus.gyp
index 3b37f42b795afd53725485d7f70ac96d51dd4d70..be8cbd7ff49f3d98d22c6c58f608e9e00abb9dbe 100644
--- a/third_party/opus/opus.gyp
+++ b/third_party/opus/opus.gyp
@@ -5,14 +5,17 @@
{
'variables': {
'conditions': [
- ['((OS=="android" or chromeos==1) and target_arch=="arm") or (OS=="ios" and target_arch=="armv7")', {
+ ['target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64"', {
'use_opus_fixed_point%': 1,
- 'use_opus_arm_optimization%': 1,
}, {
'use_opus_fixed_point%': 0,
+ }],
+ ['target_arch=="arm" or target_arch=="armv7"', {
+ 'use_opus_arm_optimization%': 1,
+ }, {
'use_opus_arm_optimization%': 0,
}],
- ['(OS=="android" or chromeos==1) and target_arch=="arm"', {
+ ['target_arch=="arm"', {
'use_opus_rtcd%': 1,
}, {
'use_opus_rtcd%': 0,
@@ -55,7 +58,7 @@
4334, # Disable 32-bit shift warning in src/opus_encoder.c .
],
}],
- [ 'os_posix==1 and OS!="android"', {
+ ['os_posix==1 and OS!="android"', {
# Suppress a warning given by opus_decoder.c that tells us
# optimizations are turned off.
'cflags': [
@@ -67,6 +70,10 @@
],
},
}],
+ ['os_posix==1 and (target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64")', {
+ 'cflags!': ['-Os'],
+ 'cflags': ['-O3'],
+ }],
['use_opus_fixed_point==0', {
'include_dirs': [
'src/silk/float',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698