Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 354873002: stub out debug::StackTrace().Print() when using uclibc (Closed)

Created:
6 years, 6 months ago by Mostyn Bramley-Moore
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, jam, haitaol+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

stub out debug::StackTrace().Print() when using uclibc This is a followup from https://codereview.chromium.org/228753003 which expands the subset of chromium that should be possible to build with uClibc. BUG=386961 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280289

Patch Set 1 #

Patch Set 2 : stub out StackTrace::Print instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/debug/stack_trace.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Mostyn Bramley-Moore
This expands a previous CL that made it possible to build content with uClibc, to ...
6 years, 6 months ago (2014-06-25 21:01:58 UTC) #1
Nicolas Zea
Seems wrong to have to #ifdef out all calls of Print, rather than just have ...
6 years, 6 months ago (2014-06-25 21:27:15 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 6 months ago (2014-06-25 22:11:32 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 6 months ago (2014-06-25 22:11:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/354873002/1
6 years, 6 months ago (2014-06-25 22:13:00 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 01:43:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 01:47:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/76459)
6 years, 6 months ago (2014-06-26 01:47:44 UTC) #8
Mostyn Bramley-Moore
@sky: can you please take a look at content/public/test/browser_test_base.cc ?
6 years, 6 months ago (2014-06-26 21:13:50 UTC) #9
sky
One comment, could we instead make base::debug::StackTrace().Print a no-op in this config so that we ...
6 years, 6 months ago (2014-06-26 22:01:39 UTC) #10
Mostyn Bramley-Moore
On 2014/06/26 22:01:39, sky wrote: > One comment, could we instead make base::debug::StackTrace().Print a no-op ...
6 years, 6 months ago (2014-06-26 23:05:32 UTC) #11
sky
THis means you no longer need me: -sky
6 years, 6 months ago (2014-06-26 23:31:12 UTC) #12
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-27 03:23:42 UTC) #13
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 6 months ago (2014-06-27 05:40:49 UTC) #14
Mostyn Bramley-Moore
The CQ bit was unchecked by mostynb@opera.com
6 years, 6 months ago (2014-06-27 05:41:06 UTC) #15
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 6 months ago (2014-06-27 05:41:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/354873002/20001
6 years, 6 months ago (2014-06-27 05:42:28 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 09:21:12 UTC) #18
Message was sent while issue was closed.
Change committed as 280289

Powered by Google App Engine
This is Rietveld 408576698