Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 354863002: MIPS: The IC exposes a register definition. (Closed)

Created:
6 years, 6 months ago by kilvadyb
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: The IC exposes a register definition. Port r22011 (be22370) Original commit message: Centralize a register definition in an IC that provides: 1) symbolic names for the register (like, edx == receiver) 2) defines ordering when passed on the stack Code that implements or uses the IC should use this definition instead of "knowing" what the registers are. Or at least have the definition to validate it's assumptions. As a side effect of avoiding runtime static initializers (enforced by tools/check-static-initializers.sh, neat), I gave ownership of the registers array to CodeStubInterfaceDescriptor. This prompted a cleanup of that struct. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -166 lines) Patch
M src/mips/code-stubs-mips.cc View 7 chunks +105 lines, -163 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/ic-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
6 years, 6 months ago (2014-06-25 15:48:12 UTC) #1
mvstanton
lgtm
6 years, 6 months ago (2014-06-25 15:49:26 UTC) #2
kilvadyb
6 years, 6 months ago (2014-06-25 16:17:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22021.

Powered by Google App Engine
This is Rietveld 408576698