Issue 354833003: Revert 279677 "Generate java bindings for structs."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354833003: Revert 279677 "Generate java bindings for structs." (Closed)

Created:
6 years, 6 months ago by pastarmovj

Modified:
6 years, 6 months ago

Reviewers:
qsr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 279677 "Generate java bindings for structs." Broke the Linux x64 build http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/66839/steps/compile/logs/stdio > Generate java bindings for structs. > > This CL introduces bindings for struct. It only generates fields and not > serialization/deserialization methods. > > R=rmcilroy@chromium.org, viettrungluu@chromium.org > > Review URL: https://codereview.chromium.org/306893010 TBR=qsr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279688

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -464 lines)			Patch
M	trunk/src/build/android/findbugs_filter/findbugs_exclude.xml	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	trunk/src/build/get_landmines.py	View	1 chunk	+1 line, -1 line	0 comments	Download
D	trunk/src/mojo/android/javatests/src/org/chromium/mojo/HandleMock.java	View	1 chunk	+0 lines, -211 lines	0 comments	Download
M	trunk/src/mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java	View	2 chunks	+25 lines, -90 lines	0 comments	Download
M	trunk/src/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	trunk/src/mojo/bindings/java/src/org/chromium/mojo/bindings/Struct.java	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	trunk/src/mojo/public/interfaces/bindings/tests/math_calculator.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/public/interfaces/bindings/tests/sample_factory.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/public/interfaces/bindings/tests/sample_import.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/public/interfaces/bindings/tests/sample_import2.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/public/interfaces/bindings/tests/sample_service.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/public/interfaces/bindings/tests/test_structs.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/mojo/public/java/src/org/chromium/mojo/system/InvalidHandle.java	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	trunk/src/mojo/public/tools/bindings/generators/java_templates/constant_definition.tmpl	View	1 chunk	+3 lines, -1 line	0 comments	Download
A +	trunk/src/mojo/public/tools/bindings/generators/java_templates/java_macros.tmpl	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/mojo/public/tools/bindings/generators/java_templates/struct.java.tmpl	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	trunk/src/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	trunk/src/mojo/public/tools/bindings/generators/mojom_java_generator.py	View	6 chunks	+21 lines, -67 lines	0 comments	Download
M	trunk/src/mojo/public/tools/bindings/mojom_bindings_generator.gypi	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/mojo/public/tools/bindings/pylib/mojom/generate/generator.py	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	trunk/src/mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py	View	2 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

6 years, 6 months ago (2014-06-25 12:37:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r279688 (tree was closed).

Expand Messages | Collapse Messages