Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 354813004: Add missing owner check to form's "named property retrieval" over images. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add missing owner check to form's "named property retrieval" over images. If the named lookup for a form doesn't match the id/name of any listed elements, the <img> elements should be considered. But only those being descendants of the form itself. The owner check simply wasn't included; added here. R=tkent@chromium.org BUG=387312 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176960

Patch Set 1 #

Patch Set 2 : Shorten out single-use local binding; no change in functionality. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M LayoutTests/fast/forms/form-radio-img-node-list.html View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/form-radio-img-node-list-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/RadioNodeList.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-25 14:45:39 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-25 23:29:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/354813004/20001
6 years, 6 months ago (2014-06-25 23:30:53 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-26 00:33:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-26 00:42:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13549)
6 years, 6 months ago (2014-06-26 00:42:48 UTC) #6
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-26 00:48:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/354813004/20001
6 years, 6 months ago (2014-06-26 00:49:21 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-26 01:07:53 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 03:44:51 UTC) #10
Message was sent while issue was closed.
Change committed as 176960

Powered by Google App Engine
This is Rietveld 408576698