Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 354763005: DevTools: timeline doesn't show records in TimelineView the first view was TimelineFlameChart view. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: unnecessary line was removed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePresentationModel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 this._presentationModel.setTextFilter(textFilter); 297 this._presentationModel.setTextFilter(textFilter);
298 this._invalidateAndScheduleRefresh(false, true); 298 this._invalidateAndScheduleRefresh(false, true);
299 }, 299 },
300 300
301 willHide: function() 301 willHide: function()
302 { 302 {
303 this._closeRecordDetails(); 303 this._closeRecordDetails();
304 WebInspector.View.prototype.willHide.call(this); 304 WebInspector.View.prototype.willHide.call(this);
305 }, 305 },
306 306
307 wasShown: function()
308 {
309 this._presentationModel.refreshRecords();
310 WebInspector.View.prototype.wasShown.call(this);
alph 2014/07/02 07:33:07 nit: Should be HBox
311 },
312
307 _onScroll: function(event) 313 _onScroll: function(event)
308 { 314 {
309 this._closeRecordDetails(); 315 this._closeRecordDetails();
310 this._scrollTop = this._containerElement.scrollTop; 316 this._scrollTop = this._containerElement.scrollTop;
311 var dividersTop = Math.max(0, this._scrollTop); 317 var dividersTop = Math.max(0, this._scrollTop);
312 this._timelineGrid.setScrollAndDividerTop(this._scrollTop, dividersTop); 318 this._timelineGrid.setScrollAndDividerTop(this._scrollTop, dividersTop);
313 this._scheduleRefresh(true, true); 319 this._scheduleRefresh(true, true);
314 }, 320 },
315 321
316 /** 322 /**
(...skipping 980 matching lines...) Expand 10 before | Expand all | Expand 10 after
1297 this._element.classList.remove("hidden"); 1303 this._element.classList.remove("hidden");
1298 } else 1304 } else
1299 this._element.classList.add("hidden"); 1305 this._element.classList.add("hidden");
1300 }, 1306 },
1301 1307
1302 _dispose: function() 1308 _dispose: function()
1303 { 1309 {
1304 this._element.remove(); 1310 this._element.remove();
1305 } 1311 }
1306 } 1312 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePresentationModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698